[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#5). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#4). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#3). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: extend netlink error cb with extra info

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email to look at the new patch set (#2). Change subject: dco_linux: extend netlink error cb with ext

[Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/819?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed

[Openvpn-devel] [XS] Change in openvpn[master]: man: extend --persist-tun section

2025-01-25 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/819?usp=email ) Change subject: man: extend --persist-tun section .. Patch Set 2:

[Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co...

2025-01-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/867?usp=email ) Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning .. tls_crypt_v2_write_client_key_file:

[Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co...

2025-01-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/867?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-

[Openvpn-devel] [PATCH applied] Re: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning

2025-01-25 Thread Gert Doering
Not sure why the compiler is more picky here than on other inits, but maybe it's "... = {2}" vs "... = {0}" (which means "all is 0", so the actual element first in the struct does not matter). Anyway, ".n = 2" is what we want so there is no harm in writing that done :-) - and the buildbots agree t

[Openvpn-devel] [PATCH v2] tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning

2025-01-25 Thread Gert Doering
From: Frank Lichtenheld GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit U

[Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co...

2025-01-25 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/867?usp=email ) Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning ..

[Openvpn-devel] [PATCH applied] Re: mroute: adapt to new protocol handling and hashing improvements

2025-01-25 Thread Gert Doering
This is also basically only "adding infrastructure" - the mroute hashing is used to find a peer based on IP address, and with UDP+TCP sockets in use at the same time, a collision "same remote IP+Port, different proto" is possible. Now, the hashing is not strictly needed for incoming packets on a T

[Openvpn-devel] [S] Change in openvpn[master]: mroute: adapt to new protocol handling and hashing improvements

2025-01-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/765?usp=email ) Change subject: mroute: adapt to new protocol handling and hashing improvements .. mroute: adapt to new protocol handling and hashing impro

[Openvpn-devel] [PATCH v3] Rename occurences of 'struct link_socket' from 'ls' to 'sock'

2025-01-25 Thread Gert Doering
From: Gianmarco De Gregori This commit renames all instances of 'struct link_socket' from the abbreviation 'ls' to the more descriptive 'sock' making it clearer that the variables represent socket-related structures. No functional changes have been introduced. Change-Id: Iff12c4dbac84a814612aa8

[Openvpn-devel] [S] Change in openvpn[master]: mroute: adapt to new protocol handling and hashing improvements

2025-01-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#18) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/765?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: mroute: adapt to new protocol handling and hashing improv