Additional context from PR on Github about changes in ssl_openssl.c around line
1900:
This change addresses a subtle behavioral difference between AWS-LC and OpenSSL
regarding object ownership semantics in SSL_CTX_set_client_CA_list(ctx->ctx,
cert_names).
OpenSSL Behavior:
Stores a reference to th
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
Change subject: Add unit tests for atoi parsing options helper
..
Add unit tests for atoi parsing options helper
Change-Id: Ieee368e325d7f
I'm not totally happy with another #ifdef added to that already-not-so-nice
#orgy, but I see no more elegant way. One might consider to move the
#define IFNAMSIZ further up, and use it in the "iface[16]" definition
(getting rid of one #ifdef)... but that's somewhat outside the scope
of this patch
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/689?usp=email )
Change subject: Haiku: Fix short interface path length
..
Haiku: Fix short interface path length
* Haiku uses full paths for interface nam
cron2 has uploaded a new patch set (#2) to the change originally created by
kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/689?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Haiku: Fix short interface path length
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add unit tests for atoi parsing options helper
Unit tests are good, and in v2, they actually pass without explosions :-)
Your patch has been applied to the master branch.
commit 2a6dbf5c6d8666a0dff586f36a867b8509d2f28d
Author: Arne Schwabe
Date: Tue Jan 28 18:58:55 2025 +0100
Add unit tests for atoi parsing options helper
Signed
cron2 has uploaded a new patch set (#2) to the change originally created by
kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Haiku: change del to delete in route command. del i
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )
Change subject: Haiku: change del to delete in route command. del is
undocumented
..
Haiku: change del to delete in route command. del is
Not much to test here :-) - patch only affects #ifdef TARGET_HAIKU blocks
and only "route" command line naming.
Your patch has been applied to the master branch.
commit 625b3e91b9a5b3283ae59cdab253a55e34feea7f
Author: Alexander von Gluck
Date: Tue Jan 28 13:41:29 2025 +0100
Haiku: change
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
Change subject: Add unit tests for atoi parsing options helper
..
Patch Set 2:
From: Arne Schwabe
Change-Id: Ieee368e325d7f9c367fd91fee0fd3e281ee0855d
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/87
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )
Change subject: mroute/management: fix uninitialized variable (UNINIT)
..
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email
to look at the new patch set (#2).
The following approvals got outdate
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/876?usp=email )
Change subject: Add unit tests for atoi parsing options helper
..
Patch
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )
Change subject: mroute/management: fix unitialized variable (UNINIT)
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/819?usp=email )
Change subject: man: extend --persist-tun section
..
Patch Set 2:
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email )
Change subject: mroute/management: fix unitialized variable (UNINIT)
...
Straight and to the point, after some initial complications due to older
Linux distributions... v9 looks good to me, comes from the Netlink master,
and both BB and GHA claim "it's not failing anything"
Your patch has been applied to the master branch.
commit edad5fa42bff2f291d7d416ccb90f4e7cd5b3
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
..
dco_linux: extend netlink error cb with extra info
A netlink error m
cron2 has uploaded a new patch set (#10) to the change originally created by
ordex. ( http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: dco_linux: extend netlink error cb with extra info
...
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/880?usp=email
to review the following change.
Change subject: mroute/management: fix unitialized variable (UNI
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/878?usp=email )
Change subject: route.c: change the signature of get_default_gateway()
.
Attention is currently required from: ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
..
Pa
From: Antonio Quartulli
A netlink error may contain more specific attributes: i.e.
missing attributes or missing neted objects.
Parse and print this information too.
Note that we are re-defining some enum entries that exist
in netlink.h starting with linux-6.1.
Since we do support distros not s
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/878?usp=email
to review the following change.
Change subject: route.c: change the signature of get_default_gat
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/879?usp=email
to review the following change.
Change subject: route.c: improve get_default_gateway() logic on
From: Alexander von Gluck
Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Signed-off-by: Alexander von Gluck
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/
From: Alexander von Gluck
* Haiku uses full paths for interface names, 16 characters
isn't enough.
Change-Id: I6de60ed5c03ea45e1d7a3fbfc8ed5075e84d
Signed-off-by: Alexander von Gluck
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
develope
Attention is currently required from: kallisti5, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )
Change subject: Haiku: change del to delete in route command. del is
undocumented
Attention is currently required from: kallisti5, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/689?usp=email )
Change subject: Haiku: Fix short interface path length
..
Pat
Attention is currently required from: cron2, ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
.
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info
.
33 matches
Mail list logo
