[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 18

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2025-02-05 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email ) Change subject: Implement epoch key data format .. Patch Set 18:

[Openvpn-devel] [XS] Change in openvpn[master]: add missing (void) to win32 function declarations

2025-02-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/886?usp=email ) Change subject: add missing (void) to win32 function declarations .. add missing (void) to win32 function declarations mingw complains abo

[Openvpn-devel] [XS] Change in openvpn[master]: add missing (void) to win32 function declarations

2025-02-05 Thread cron2 (Code Review)
Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/886?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: add missing (void) to

[Openvpn-devel] [PATCH applied] Re: add missing (void) to win32 function declarations

2025-02-05 Thread Gert Doering
Found these while testing #815 on ubuntu/mingw... Patch has been applied to the master branch. commit 817577d56ba48e160d4c7ad939ce62a93b55ab7f Author: Gert Doering Date: Wed Feb 5 18:02:32 2025 +0100 add missing (void) to win32 function declarations Signed-off-by: Gert Doering

[Openvpn-devel] [PATCH v1] add missing (void) to win32 function declarations

2025-02-05 Thread Gert Doering
mingw complains about "old-style function definition" and since we use explicit (void) everyhwere else... Change-Id: I59e34058d6e0611208767fbcf39d1b91784ebcf9 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2025-02-05 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email ) Change subject: Implement epoch key data format .. Patch Set 18:

[Openvpn-devel] [XS] Change in openvpn[master]: add missing (void) to win32 function declarations

2025-02-05 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/886?usp=email ) Change subject: add missing (void) to win32 function declarations .

[Openvpn-devel] [XS] Change in openvpn[master]: add missing (void) to win32 function declarations

2025-02-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/886?usp=email to review the following change. Change subject: add missing (void) to win32 function declaration

[Openvpn-devel] IRC community meeting summary

2025-02-05 Thread Johan Draaisma
Meeting summary for 5 February 2025: * *New: OpenSSL update with vulnerability severity "HIGH" is dropping next week.* /This might not really affect us but we will likely have to do a 2.6.13 I002 binary for Windows./ * *New: Windows MSI snapshots not updating* /lev asks if this can

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/885?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: disable dco in server mode if multiple --local option

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/885?usp=email ) Change subject: dco-win: disable dco in server mode if multiple --local options defined .. dco-win: disable dco in server mode if multiple

[Openvpn-devel] [PATCH applied] Re: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread Gert Doering
As discussed on IRC - this is a preliminary patch for making sure the windows "multi-peer support in DCO" patchset and the "multi-socket patchset" can cooperate peacefully, while win-dco has no multi-socket capability yet (due to the way win-dco socket handling differs from linux-dco/freebsd-dco, t

[Openvpn-devel] [PATCH v2] dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread Gert Doering
From: Lev Stipakov dco-win doesn't yet support multisocket, so for the time being we have to fallback to tap-windows6. Change-Id: I8724eda269b816dd2cfd0833d467e6d24054e96f Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one de

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/885?usp=email ) Change subject: dco-win: disable dco in server mode if multiple --local options defined ...

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/885?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [PATCH v1] dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread Gert Doering
From: Lev Stipakov dco-win doesn't yet support multisocket, so for the time being we have to fallback to tap-windows6. Change-Id: I8724eda269b816dd2cfd0833d467e6d24054e96f Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one de

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/885?usp=email ) Change subject: dco-win: disable dco in server mode if multiple --local options defined ...

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/885?usp=email to review the following change. Change subject: dco-win: disable dco in server mode if multiple