[Openvpn-devel] [PATCH] Add 'localhost' token to client-nat network option

2025-02-20 Thread Rafael Gava
Dear OpenVPN Community, I am submitting this patch to introduce a 'localhost' token to the `client-nat` network option, allowing OpenVPN clients to dynamically use the IP address provided by the server. This enhancement is particularly useful in scenarios where OpenVPN is deployed as a VPN gateway

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: support for iroutes

2025-02-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#16) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/857?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: support for iroutes

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: support for iroutes

2025-02-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/857?usp=email ) Change subject: dco-win: support for iroutes .. dco-win: support for iroutes Unlike Linux/FreeBSD, dco-win doesn't have access to a system

[Openvpn-devel] [PATCH applied] Re: dco-win: support for iroutes

2025-02-20 Thread Gert Doering
Tested IPv4/IPv6 iroutes on my Windows 10 VM, gave interesting results and nice blue screens ;-) - but the userland / OpenVPN part did exactly what we wanted it to do. The kernel side has some issues with host routes, but Lev is working on it. The userland API won't change, so this can proceed ne

[Openvpn-devel] [PATCH v15] dco-win: support for iroutes

2025-02-20 Thread Gert Doering
From: Lev Stipakov Unlike Linux/FreeBSD, dco-win doesn't have access to a system routing table, so we have to maintain internal routing table in the driver. For that, we have 4 ioctls to add/delete IPv4/IPv6 iroutes. When adding iroute, we pass peer-id, so that the driver is able to associate a s

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: support for iroutes

2025-02-20 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/857?usp=email ) Change subject: dco-win: support for iroutes .. Patch Set

[Openvpn-devel] [PATCH applied] Re: Remove x509-username-fields uppercasing

2025-02-20 Thread Gert Doering
Acked-by: Gert Doering Thanks for helping us get rid of our technical debt ;-) - and indeed, if we declared it obsolete years ago, it should go now. Someone will complain, but this is not something which can't be fixed with a small config change. I have not tested this beyond a GHA test run (wh

Re: [Openvpn-devel] [PATCH applied] Re: Document x509-username-fields oid usage

2025-02-20 Thread Gert Doering
Hi, On Thu, Feb 20, 2025 at 10:50:31AM +0100, Gert Doering wrote: > Acked-by: Gert Doering > > This is an interesting find :-) - if we can do this, we can as well > document it. Thanks. > > (I have not actually tested this, but "man OBJ_txt2obj" confirms) > > Your patch has been applied to th

[Openvpn-devel] [PATCH applied] Re: Document x509-username-fields oid usage

2025-02-20 Thread Gert Doering
Acked-by: Gert Doering This is an interesting find :-) - if we can do this, we can as well document it. Thanks. (I have not actually tested this, but "man OBJ_txt2obj" confirms) Your patch has been applied to the master branch. commit 9f17ad7c281360ec0e970af23f9ba0dc892665c6 Author: corubba v

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email ) Change subject: dco-win: kernel notifications .. dco-win: kernel notifications The driver supports notifications mechanism, which is used

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#22) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: kernel notifications ...

[Openvpn-devel] [PATCH applied] Re: dco-win: kernel notifications

2025-02-20 Thread Gert Doering
Tested v20 on a Windows server as part of the tests for #815 - the directly-visible bit for #816 is "make --timeout work". I did not test key rollover, though. v20->v21 is comment + style, so did not re-test beyond a quick compile test locally and waiting for the buildbots to be happy with it. Y

[Openvpn-devel] [PATCH v21] dco-win: kernel notifications

2025-02-20 Thread Gert Doering
From: Lev Stipakov The driver supports notifications mechanism, which is used to notify userspace about various events, such as peer keepalive timeout, key expire and so on. This uses existing framework of subscribing and receiving dco notifications, used by FreeBSD and Linux implementations. On

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email ) Change subject: dco-win: kernel notifications .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email ) Change subject: dco-win: kernel notifications .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/816?usp=email to look at the new patch set (#21). The following approvals got outdated a

[Openvpn-devel] [XS] Change in openvpn[master]: dco-win: simplify control packets prepend code

2025-02-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/900?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: simplify control packets prepend code ...

[Openvpn-devel] [XS] Change in openvpn[master]: dco-win: simplify control packets prepend code

2025-02-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/900?usp=email ) Change subject: dco-win: simplify control packets prepend code .. dco-win: simplify control packets prepend code Eliminate unneeded tempor

[Openvpn-devel] [PATCH applied] Re: dco-win: simplify control packets prepend code

2025-02-20 Thread Gert Doering
Straightforward, so I have not actually tested the resulting openvpn.exe - but stared very hard at the change & asked MinGW for an opinion (no errors or warnings). Fixed one whitespace gotcha on the fly. Your patch has been applied to the master branch. commit a8e67c7d0642f6b7e12ffc98af8495e