[Openvpn-devel] [S] Change in openvpn[master]: Improve documentation for override-username

2025-04-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/914?usp=email ) Change subject: Improve documentation for override-username .. Improve documentation for override-username - Mention that pushing auth-tok

[Openvpn-devel] [PATCH applied] Re: GHA: Make sure renovate notifies us about AWS LC releases

2025-04-05 Thread Gert Doering
This only does magic comments - so there is not much to test (GHA is not upset if I push this, but besides this, I just believe it does what it's supposed to do). Your patch has been applied to the master branch. commit b75849ba3641227ff66430ea06423fab8148 Author: Frank Lichtenheld Date: We

[Openvpn-devel] [PATCH applied] Re: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-04-05 Thread Gert Doering
I have not tested this further - the buildbots have, and both the release notes and our mbedTLS expert agree on the fix :-) Tested compilation for the 2.6 backport via GHA. Your patch has been applied to the master and release/2.6 branch (long-term compat). commit 4897c522948c8cdb82c0325ee08f690

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: Ensure correct OVERLAPPED scope

2025-04-05 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/933?usp=email to review the following change. Change subject: dco-win: Ensure correct OVERLAPPED scope ...

[Openvpn-devel] [PATCH applied] Re: socket: use remote proto when creating client sockets

2025-04-05 Thread Gert Doering
Yeah, too many protos around... Arne and Lev confirm that this is what is needed to un-confuse "--local " and "--remote " and general "--" (--udp4 etc) for the client case... Tested with standard and extended t_client test set (extended = one stanza that has multiple --remote with different proto

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-04-05 Thread stipa (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: Fix crash when cancelling pending operation

2025-04-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/928?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: Fix crash when cancelling pending operation .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-04-05 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems ..

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-04-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email ) Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ .. Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ From release note

[Openvpn-devel] [PATCH v1] Fix incorrect condition for checking password related check

2025-04-05 Thread Gert Doering
From: Arne Schwabe Commit db48cea chagned logic to move logic from a variable and repeated checks to an if clause. The old code had const bool ccnr = (options->auth_user_pass_verify_script || PLUGIN_OPTION_LIST(options)

[Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project

2025-04-05 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/790?usp=email ) Change subject: Define a .clang-format file for the project .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: Mention address if not unspecific on DNS failure

2025-04-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/909?usp=email ) Change subject: Mention address if not unspecific on DNS failure .. Mention address if not unspecific on DNS failure With the recent chang

[Openvpn-devel] [S] Change in openvpn[master]: Mention address if not unspecific on DNS failure

2025-04-05 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/909?usp=email to look at the new patch set (#3). Change subject: Mention address if not unspecific on DNS failure ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: GHA: Pin version of CMake for MinGW build

2025-04-05 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/930?usp=email to review the following change. Change subject: GHA: Pin version of CMake for MinGW build ...

[Openvpn-devel] [L] Change in openvpn[master]: Apply text-removal.sh script to Windows codebase

2025-04-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/853?usp=email ) Change subject: Apply text-removal.sh script to Windows codebase ...

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update April 2025

2025-04-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/926?usp=email ) Change subject: GHA: Dependency and Actions update April 2025 .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid

2025-04-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/927?usp=email to look at the new patch set (#2). Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signat

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-04-05 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email ) Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null_default.rc: Add some tests with --data-ciphers

2025-04-05 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/847?usp=email ) Change subject: t_server_null_default.rc: Add some tests with --data-ciphers

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ...

2025-04-05 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email to look at the new patch set (#12). The following approvals got outdated and were rem

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: Ensure correct OVERLAPPED scope

2025-04-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/933?usp=email ) Change subject: dco-win: Ensure correct OVERLAPPED scope .. dco-win: Ensure correct OVERLAPPED scope This is a backport of the master comm