[Openvpn-devel] [M] Change in openvpn[master]: Remove contrib/pull-resolv-conf

2025-05-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1034?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove contrib/pull-resolv-conf ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove contrib/pull-resolv-conf

2025-05-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1034?usp=email ) Change subject: Remove contrib/pull-resolv-conf .. Remove contrib/pull-resolv-conf We have an official solution for this now. Change-Id:

[Openvpn-devel] [PATCH applied] Re: Remove contrib/pull-resolv-conf

2025-05-28 Thread Gert Doering
Indeed - "because why ship something which is not doing a good job when we have something new that does a better job" ;-) - and out it goes. Your patch has been applied to the master branch. commit 26a5c094bddbf528be4f6f2f26d9831717d5139d Author: Frank Lichtenheld Date: Wed May 28 21:11:20 2025

[Openvpn-devel] [PATCH v1] Remove contrib/pull-resolv-conf

2025-05-28 Thread Gert Doering
From: Frank Lichtenheld We have an official solution for this now. Change-Id: Ic30f8514b50f561e7ea8f1ce12d740ac53f202e5 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerr

[Openvpn-devel] [M] Change in openvpn[master]: Remove contrib/pull-resolv-conf

2025-05-28 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1034?usp=email ) Change subject: Remove contrib/pull-resolv-conf .. Patch Set 1:

[Openvpn-devel] [S] Change in openvpn[master]: Add missing header in unit tests Makefile.am

2025-05-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1033?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~ChecksSubmitRule is

[Openvpn-devel] [PATCH v3] Add missing header in unit tests Makefile.am

2025-05-28 Thread Gert Doering
From: Arne Schwabe make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer.

[Openvpn-devel] [M] Change in openvpn[master]: Remove contrib/pull-resolv-conf

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1034?usp=email to review the following change. Change subject: Remove contrib/pull-resolv-conf ...

[Openvpn-devel] [PATCH v2] Add missing header in unit tests Makefile.am

2025-05-28 Thread Gert Doering
From: Max Fillinger make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer.

[Openvpn-devel] [S] Change in openvpn[master]: Add missing header in unit tests Makefile.am

2025-05-28 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1033?usp=email ) Change subject: Add missing header in unit tests Makefile.am ..

[Openvpn-devel] [S] Change in openvpn[master]: Add missing header in unit tests Makefile.am

2025-05-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1033?usp=email to look at the new patch set (#2). Change subject: Add missing header in unit tests Makefile.am ..

[Openvpn-devel] [S] Change in openvpn[master]: Add missing header in unit tests Makefile.am

2025-05-28 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1033?usp=email to review the following change. Change subject: Add missing header in unit tests Makefile.am

[Openvpn-devel] [PATCH ovpn-net-next] ovpn: pktid: use bitops.h API

2025-05-28 Thread Qingfang Deng
Use bitops.h for replay window to simplify code. Signed-off-by: Qingfang Deng --- drivers/net/ovpn/pktid.c | 11 --- drivers/net/ovpn/pktid.h | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/ovpn/pktid.c b/drivers/net/ovpn/pktid.c index 2f29049897e3..f1

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release .

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email to look at the new patch set (#5). Change subject: Changes.rst: Collect, fix, and improve entrie

[Openvpn-devel] [S] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email ) Change subject: mbedtls: Allow TLS 1.3 if available .. Patch Set 3: Code-Rev

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release .