[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email ) Change subject: dco_linux: enable extended netlink error reporting .. dco_linux: enable extended netlink error reporting The ovpn netlink

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco_linux: enable extended netlink error reporting ..

[Openvpn-devel] [PATCH applied] Re: dco_linux: enable extended netlink error reporting

2025-06-09 Thread Gert Doering
Tested, makes sense - I intentionally broke some code parts in dco_linux.c that set up a peer, and instead of a not very helpful "-7" userspace now gets a proper error string. Discovered the extra "\n" testing this, so thanks for the v2 fix :-) Your patch has been applied to the master branch. c

[Openvpn-devel] [PATCH v2] dco_linux: enable extended netlink error reporting

2025-06-09 Thread Gert Doering
From: Antonio Quartulli The ovpn netlink code reports more verbose error strings to help userspace understand what went wrong, rather than just returning, for example, -EINVAL. However, userspace must instruct the kernel netlink subsystem that it wants to receive such strings. code for parsing

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-09 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email ) Change subject: dco_linux: enable extended netlink error reporting

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: enable extended netlink error reporting

2025-06-09 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1040?usp=email to look at the new patch set (#2). The following approvals got outdated a