[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2025-06-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table ..

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails

2025-06-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email ) Change subject: t_server_null: print error when server startup fails .. t_server_null: print error when server startup fails Use "&" to b

[Openvpn-devel] [PATCH applied] Re: t_server_null: print error when server startup fails

2025-06-18 Thread Gert Doering
v3 looks good and does the job :-) - it needed a bit of massaging because the context has changed (commit 4d104a385) and because it really wants to go on top of #915 - but that's the wrong order, the "we want to see the failures?!" patch needs to go in before the one that triggers new failures...

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails

2025-06-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: t_server_null: print error when server startup fails ..

[Openvpn-devel] [PATCH applied] Re: Multi-socket: local_list clean-up

2025-06-18 Thread Gert Doering
Stared-at-code, looks good. Tested on the server instance with lots of --local lines (+ some msg() calls to see l->len and l_capacity), and it does what it promises. Thanks :-) Your patch has been applied to the master branch. commit 9bb02bc34f5ecc85364fa7ab64e52b6c5c918055 Author: Gianmarco De

[Openvpn-devel] [PATCH v3] t_server_null: print error when server startup fails

2025-06-18 Thread Gert Doering
From: Samuli Seppänen Use "&" to background so that the exit code and all output can be obtained in all failure cases. Change-Id: I39dc6b08952a06dae7901e468f9487c8541d83c3 Signed-off-by: Samuli Seppänen Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails

2025-06-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email ) Change subject: t_server_null: print error when server startup fails

[Openvpn-devel] [S] Change in openvpn[master]: Multi-socket: local_list clean-up

2025-06-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1039?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Multi-socket: local_list clean-up ...

[Openvpn-devel] [S] Change in openvpn[master]: Multi-socket: local_list clean-up

2025-06-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1039?usp=email ) Change subject: Multi-socket: local_list clean-up .. Multi-socket: local_list clean-up Optimize the current local_list implementation by

[Openvpn-devel] [S] Change in openvpn[master]: Multi-socket: local_list clean-up

2025-06-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1039?usp=email ) Change subject: Multi-socket: local_list clean-up ..

[Openvpn-devel] [PATCH v1] Multi-socket: local_list clean-up

2025-06-18 Thread Gert Doering
From: Gianmarco De Gregori Optimize the current local_list implementation by replacing the static array with a resizable one, as the static allocation serves no real purpose, particularly on the client side. Github: #682 Change-Id: I32effed9e273fbe8986d1f4e8da4a4d0ac216463 Signed-off-by: Gianma

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .. dns: deal with --dhcp-options when --dns is active Since --dns setti

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#25) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dns: deal with --dhcp-options when --dns is active ..

[Openvpn-devel] [PATCH applied] Re: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread Gert Doering
So - finally the Grand DNS Rewrite is reaching the final commits - thanks Heiko for all the work. This patch brings working --dns-updown for configs where the server still pushes "dhcp-options DNS" - and vice versa, compat "foreign_option..." settings in --up for configs where the server pushes "-

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active ..

[Openvpn-devel] [PATCH v24] dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread Gert Doering
From: Heiko Hund Since --dns settings overrule DNS related --dhcp-options, remove the latter when values were defined via --dns. To stay as backward compatible as possible, we add foreign_options to the script hook environment from the --dns values when a --up script is defined. In that case the

[Openvpn-devel] IRC community meeting summary

2025-06-18 Thread Johan Draaisma
Meeting summary for 18 June 2025: * *Updated, closed: (embargo) security issue* CVE ID CVE-2025-50054 reserved for this security issue. For OpenVPN 2.6 the Windows installer will be updated. For OpenVPN 2.7 a new alpha2 release will be made. Estimated delivery date 19 june 2025.

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-06-18 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to look at the new patch set (#24). Change subject: dns: deal with --dhcp

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-18 Thread plaisthos (Code Review)
Attention is currently required from: comododragon, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email ) Change subject: Added PQE to WolfSSL .. Patch Set 1: (1

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-06-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email ) Change subject: fix typo in haikuos dns-updown script .. fix typo in haikuos dns-updown script Change-Id: I48cec222d46c67e6620281cd8b2346

[Openvpn-devel] [PATCH applied] Re: fix typo in haikuos dns-updown script

2025-06-18 Thread Gert Doering
It would certainly help to actually test things on the right target platform... but this typo fix is obviously-correct. Your patch has been applied to the master branch. commit 51b7dc5c1093b6df82aefd464873acb9ffc93882 Author: Heiko Hund Date: Wed Jun 18 08:48:53 2025 +0200 fix typo in ha

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-06-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: fix typo in haikuos dns-updown script ...

[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

2025-06-18 Thread comododragon (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email to review the following change. Change subject: Added PQE to WolfSSL ..

[Openvpn-devel] [S] Change in openvpn[master]: Removed trailing whitespaces

2025-06-18 Thread comododragon (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1045?usp=email to review the following change. Change subject: Removed trailing whitespaces ..

[Openvpn-devel] [S] Change in openvpn[master]: Removed trailing whitespaces

2025-06-18 Thread comododragon (Code Review)
comododragon has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1045?usp=email ) Change subject: Removed trailing whitespaces .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1045?usp=email T