Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
...
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
...
Attention is currently required from: cron2, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 b
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
..
cron2 has uploaded a new patch set (#4) to the change originally created by
d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1073?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: prevent search domain races with macOS dns-updown
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1073?usp=email )
Change subject: prevent search domain races with macOS dns-updown
..
prevent search domain races with macOS dns-updown
When connections g
Explanation sonds logical, Arne is using it in production and can no
longer find issues, so in it goes. I have just briefly looked at the
script for obvious typos.
Your patch has been applied to the master branch.
commit 4848df2fb295740a7fb5a5b44f1baaeeb43307cb
Author: Heiko Hund
Date: Mon Jul
From: Heiko Hund
When connections go up and down there are situations where search
domains of a split DNS connection are either lost, or survive the
lifetime of the connction. This can happen when there is also a
connection that modifies the global DNS setting. When it backs-up the
global setting
In ovpn_nl_key_swap_doit, the attributes array used to parse the
OVPN_A_KEYCONF uses OVPN_A_PEER_MAX instead of
OVPN_A_KEYCONF_MAX. Note that this does not cause any bug, since
currently OVPN_A_KEYCONF_MAX < OVPN_A_PEER_MAX.
Fixes: 203e2bf55990 ("ovpn: implement key add/get/del/swap via netlink")
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
...
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email )
Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled
...
Attention is currently required from: flichtenheld.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email )
Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email
to look at the new patch set (#5).
Change subject: Cleanup/simplify mbed TLS related define from autocon
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email
to look at the new patch set (#6).
Change subject: Cleanup/simplify mbed TLS related define from autocon
Attention is currently required from: d12fk, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1073?usp=email )
Change subject: prevent search domain races with macOS dns-updown
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email )
Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email
to review the following change.
Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled
...
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email
to look at the new patch set (#4).
Change subject: Cleanup/simplify mbed TLS related define from autocon
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1081?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 b
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email
to review the following change.
Change subject: dco: Add support for float notifications
..
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1082?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Fix compiler warning in reliable.c with --disable-
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1082?usp=email )
Change subject: Fix compiler warning in reliable.c with --disable-debug
..
Fix compiler warning in reliable.c with --disable-debug
Use th
Interesting trick :-)
Looking forward to see the first patch come in to remove this "totally
useless line" again. But that's what "git blame" is for...
Since the buildbots are happy and this line explicitly does nothing
I have not tested this further.
Your patch has been applied to the master b
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1083?usp=email )
Change subject: reliable: Review and fix gc_arena usage
..
Patch
24 matches
Mail list logo