Re: [Openvpn-devel] [PATCH] OpenSolaris/OpenIllumos: use /bin/bash if available for test scripts.

2019-10-09 Thread Casper . Dik
>t_client.sh relies on "echo -e" and "echo -n" to produce nicely >looking output, which fails on Solaris /bin/sh - force SHELL=/bin/bash >on recent-enough Solaris variants that have it. Where recent is "Solaris 8 or later" I.e., just under 20 years old. :-) Can't tell how which version of bas

Re: [Openvpn-devel] [PATCH 1/6] sitnl: harden strncpy() by forcing arguments to have the same length

2019-08-05 Thread Casper . Dik
>For this reason, force both strings to use IFNAMSIZ as size and, since >this constant may not exist on every platform, ensure it is always >defined. A problem with this patch misght be that strncpy() does NOT NUL terminates the copied string. (It writes EXACTLY IFNAMSIZ bytes but only when th

Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2017-09-20 Thread Casper . Dik
>Hello. > >Spent a day debugging this issue on OpenIndiana. >If anyone steps on this once again... >It seems the issue was caused OI/Solaris OpenSSL specific patches, in >particular by >https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/library/openssl/openssl-1.0. 2/patches/0

Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2017-08-30 Thread Casper . Dik
>Am 30.08.17 um 10:39 schrieb casper@oracle.com: >> >> After I figured out where we went wrong, I filed: 26336744 Solaris specific cleanup code breaks gcm_aes for, e.g., openvpn which has now been fixed in oracle solaris-userland on git hub https://github.com/oracle/solar

Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2017-08-30 Thread Casper . Dik
>> After I figured out where we went wrong, I filed: >> 26336744 Solaris specific cleanup code breaks gcm_aes for, e.g., openvpn >> which has now been fixed in oracle solaris-userland on git hub >> https://github.com/oracle/solaris-userland/tree/master/components/openssl > >Cool, thanks a lot! >

Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2017-08-29 Thread Casper . Dik
I recently run into the same problem as Jens Neuhalfen has reported more than a year ago in this mailing list. As I was somewhat confused why the shipped Solaris openssl version failed, I looked into that issue as I also wanted to run a recent openvpn on Solaris 11.x. After I figured out where