Re: [Openvpn-devel] [PATCH] Add compatibility to build OpenVPN with AWS-LC.

2025-01-29 Thread Arne Schwabe
The changes are quite small and the change that  affects other crypto libraries is well documented Acked-By: Arne Schwabe Am 28.01.2025 um 23:09 schrieb Shubham Mittal: Additional context from PR on Github about changes in ssl_openssl.c around line 1900: This change addresses a subtle behavi

[Openvpn-devel] [PATCH] Add compatibility to build OpenVPN with AWS-LC.

2025-01-28 Thread Shubham Mittal via Openvpn-devel
Additional context from PR on Github about changes in ssl_openssl.c around line 1900: This change addresses a subtle behavioral difference between AWS-LC and OpenSSL regarding object ownership semantics in SSL_CTX_set_client_CA_list(ctx->ctx, cert_names). OpenSSL Behavior: Stores a reference to th

Re: [Openvpn-devel] [PATCH] Add compatibility to build OpenVPN with AWS-LC.

2025-01-27 Thread Gert Doering
Hi, On Mon, Jan 27, 2025 at 03:50:14PM -0800, Shubham Mittal via Openvpn-devel wrote: > +export LD_LIBRARY_PATH="${AWS_LC_INSTALL_FOLDER}/lib" This does not sound like a good way to get reliable operation - much better is to use -Wl,-rpath at compile time. gert -- "If was one thing all peo

[Openvpn-devel] [PATCH] Add compatibility to build OpenVPN with AWS-LC.

2025-01-27 Thread Shubham Mittal via Openvpn-devel
Additional context from PR on Github about changes in ssl_openssl.c around line 1900: This change addresses a subtle behavioral difference between AWS-LC and OpenSSL regarding object ownership semantics in SSL_CTX_set_client_CA_list(ctx->ctx, cert_names). OpenSSL Behavior: Stores a reference to