Re: [Openvpn-devel] [PATCH] Implement server_poll_timeout for socks

2024-03-06 Thread Frank Lichtenheld
On Wed, Aug 30, 2023 at 10:56:41PM +0200, Sandro Trianni wrote: > Thanks for your feedback! I'm used to describing my patches in pull > requests. Submitting it via mailing list was new to me, sorry. I hope this > reply ends up in the right thread. The patch is regarding this 10 year old > Bug https

Re: [Openvpn-devel] [PATCH] Implement server_poll_timeout for socks

2023-08-30 Thread Sandro Trianni
Thanks for your feedback! I'm used to describing my patches in pull requests. Submitting it via mailing list was new to me, sorry. I hope this reply ends up in the right thread. The patch is regarding this 10 year old Bug https://community.openvpn.net/openvpn/ticket/328 Hardcoded 5 sec timeout is t

Re: [Openvpn-devel] [PATCH] Implement server_poll_timeout for socks

2023-08-30 Thread Antonio Quartulli
Hi Sandro, at a first glance the patch looks reasonable. However, we truly need you to write some commit message explaining what your patch is fixing/implementing, why it is doing so and what problem it solves. Cheers, On 30/08/2023 15:05, 5andr0 wrote: --- src/openvpn/socket.c | 2 ++

[Openvpn-devel] [PATCH] Implement server_poll_timeout for socks

2023-08-30 Thread 5andr0
--- src/openvpn/socket.c | 2 ++ src/openvpn/socks.c | 25 ++--- src/openvpn/socks.h | 2 ++ 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 501e023e..10fd0e26 100644 --- a/src/openvpn/socket.c +++ b/src/ope