[Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-22 Thread Frank Lichtenheld
From: Selva Nair - Do not use non-literal initializers for static objects - Replace empty initializer {} by {0} Change-Id: Ifb961a4df2b8b8300633192e1a268669f6f41a35 Signed-off-by: Selva Nair Acked-by: Heiko Hund Acked-by: Selva Nair Acked-by: Lev Stipakov Co-authored-by: Frank Lichtenheld

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-28 Thread Matthias Andree
Am 28.03.23 um 10:47 schrieb Frank Lichtenheld: On Mon, Mar 27, 2023 at 09:45:53PM +0200, Matthias Andree wrote: Am 27.03.23 um 16:45 schrieb Selva Nair: Hi, On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree wrote: Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > From: Selva

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-28 Thread Frank Lichtenheld
On Mon, Mar 27, 2023 at 09:45:53PM +0200, Matthias Andree wrote: > Am 27.03.23 um 16:45 schrieb Selva Nair: > > Hi, > > > > On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree > > wrote: > > > > Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > > > From: Selva Nair > > > > > > -

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread Matthias Andree
Am 27.03.23 um 16:45 schrieb Selva Nair: Hi, On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree wrote: Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > From: Selva Nair > > - Do not use non-literal initializers for static objects > - Replace empty initializer {} by {0}

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread Selva Nair
Hi, On Mon, Mar 27, 2023 at 9:59 AM Matthias Andree wrote: > Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: > > From: Selva Nair > > > > - Do not use non-literal initializers for static objects > > - Replace empty initializer {} by {0} > > Should we go to a revision, I would suggest to not

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread Matthias Andree
Am 27.03.23 um 13:49 schrieb selva.n...@gmail.com: From: Selva Nair - Do not use non-literal initializers for static objects - Replace empty initializer {} by {0} Should we go to a revision, I would suggest to not make something compliant to a compiler because that is assigning it way too

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread Selva Nair
On Mon, Mar 27, 2023 at 8:09 AM Frank Lichtenheld wrote: > On Mon, Mar 27, 2023 at 07:49:37AM -0400, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > - Do not use non-literal initializers for static objects > > - Replace empty initializer {} by {0} > > > > Signed-off-by: Selva Nair >

Re: [Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread Frank Lichtenheld
On Mon, Mar 27, 2023 at 07:49:37AM -0400, selva.n...@gmail.com wrote: > From: Selva Nair > > - Do not use non-literal initializers for static objects > - Replace empty initializer {} by {0} > > Signed-off-by: Selva Nair > --- > To be applied after the test-pkcs11 patch set Tested MSVC build

[Openvpn-devel] [PATCH] Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-03-27 Thread selva . nair
From: Selva Nair - Do not use non-literal initializers for static objects - Replace empty initializer {} by {0} Signed-off-by: Selva Nair --- To be applied after the test-pkcs11 patch set tests/unit_tests/openvpn/cert_data.h | 6 ++--- tests/unit_tests/openvpn/test_cryptoapi.c | 24