Re: [Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

2016-12-06 Thread Alberto Gonzalez Iniesta
On Mon, Dec 05, 2016 at 09:05:04PM +0100, Gert Doering wrote: > Hi, > > On Mon, Dec 05, 2016 at 08:01:14PM +0100, Alberto Gonzalez Iniesta wrote: > > The patch, after being adjusted to the new source, is not working anymore: > > > > Mon Dec 5 19:39:34 2016 Set FD_CLOEXEC flag on file descriptor

Re: [Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

2016-12-05 Thread Gert Doering
Hi, On Mon, Dec 05, 2016 at 08:01:14PM +0100, Alberto Gonzalez Iniesta wrote: > The patch, after being adjusted to the new source, is not working anymore: > > Mon Dec 5 19:39:34 2016 Set FD_CLOEXEC flag on file descriptor failed: Bad > file descriptor (errno=9) > Mon Dec 5 19:39:34 2016 Set

Re: [Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

2016-12-05 Thread Alberto Gonzalez Iniesta
On Wed, Nov 23, 2016 at 07:43:21PM +0100, Gert Doering wrote: > Hi, > > On Wed, Nov 23, 2016 at 11:20:18AM +0100, Gert Doering wrote: > > The existing code can leak socket FDs to the "--up" script, which is > > not desired. Brought up by Alberto Gonzalez Iniesta, based on debian > > bug 367716.

Re: [Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

2016-11-23 Thread Gert Doering
Hi, On Wed, Nov 23, 2016 at 11:20:18AM +0100, Gert Doering wrote: > The existing code can leak socket FDs to the "--up" script, which is > not desired. Brought up by Alberto Gonzalez Iniesta, based on debian > bug 367716. I'm not sure if that patch is good enough yet. Arne brought up

[Openvpn-devel] [PATCH] Refactor setting close-on-exec for socket FDs

2016-11-23 Thread Gert Doering
The existing code can leak socket FDs to the "--up" script, which is not desired. Brought up by Alberto Gonzalez Iniesta, based on debian bug 367716. Since different sockets get create at different times, just moving the set_cloexec() to link_socket_init_phase1() is not good enough - so move the