Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Christian Hesse
David Sommerseth on Thu, 2017/08/24 20:16: > On 24/08/17 09:57, Antonio Quartulli wrote: > > My effort in writing the commit message has been quite poor. > > > > The assignment is useless because 'ret' is re-assigned a few lines later > > without ever being

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Christian Hesse
David Sommerseth on Thu, 2017/08/24 20:51: > On 24/08/17 20:40, Antonio Quartulli wrote: > > > > > > On 25/08/17 02:40, Christian Hesse wrote: > >> David Sommerseth on Thu, 2017/08/24 > >> 20:16: > >>> On 24/08/17 09:57,

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread David Sommerseth
On 24/08/17 20:40, Antonio Quartulli wrote: > > > On 25/08/17 02:40, Christian Hesse wrote: >> David Sommerseth on Thu, 2017/08/24 >> 20:16: >>> On 24/08/17 09:57, Antonio Quartulli wrote: My effort in writing the commit message has been quite poor.

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
On 25/08/17 02:40, Christian Hesse wrote: > David Sommerseth on Thu, 2017/08/24 20:16: >> On 24/08/17 09:57, Antonio Quartulli wrote: >>> My effort in writing the commit message has been quite poor. >>> >>> The assignment is useless because 'ret' is

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread David Sommerseth
On 24/08/17 09:57, Antonio Quartulli wrote: > My effort in writing the commit message has been quite poor. > > The assignment is useless because 'ret' is re-assigned a few lines later > without ever being read. Hmmm. I'm not convinced of this change. But I'm also weird in these cases :) I

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
My effort in writing the commit message has been quite poor. The assignment is useless because 'ret' is re-assigned a few lines later without ever being read. Cheers, On 24/08/17 15:53, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > src/openvpn/multi.h |

[Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- src/openvpn/multi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/multi.h b/src/openvpn/multi.h index 5892ac07..6cdb0110 100644 --- a/src/openvpn/multi.h +++ b/src/openvpn/multi.h @@ -633,7 +633,7 @@