Re: [Openvpn-devel] [PATCH] tls-crypt: introduce tls_crypt_kt()

2017-08-12 Thread Steffan Karger
Hi, On 12-08-17 06:36, Antonio Quartulli wrote: > On 25/07/17 22:33, Steffan Karger wrote: >> @@ -60,23 +60,9 @@ setup(void **state) { >> struct test_context *ctx = calloc(1, sizeof(*ctx)); >> *state = ctx; >> >> -ctx->kt.cipher = cipher_kt_get("AES-256-CTR"); >> -ctx->kt.diges

Re: [Openvpn-devel] [PATCH] tls-crypt: introduce tls_crypt_kt()

2017-08-11 Thread Antonio Quartulli
Hi, On 25/07/17 22:33, Steffan Karger wrote: > Reduces code duplication: less lines, same functionality. > > Because cipher_ctx_block_size() is a static function we now need to > include tls_crypt.c from the tests, rather than tls_crypt.h. > > Signed-off-by: Steffan Karger > --- > src/openvpn/

Re: [Openvpn-devel] [PATCH] tls-crypt: introduce tls_crypt_kt()

2017-07-25 Thread Steffan Karger
On 25-07-17 16:33, Steffan Karger wrote: > Because cipher_ctx_block_size() is a static function we now need to > include tls_crypt.c from the tests, rather than tls_crypt.h. Hm, something went wrong with the paste buffers. s/cipher_ctx_block_size/tls_crypt_kt/ -Steffan --

[Openvpn-devel] [PATCH] tls-crypt: introduce tls_crypt_kt()

2017-07-25 Thread Steffan Karger
Reduces code duplication: less lines, same functionality. Because cipher_ctx_block_size() is a static function we now need to include tls_crypt.c from the tests, rather than tls_crypt.h. Signed-off-by: Steffan Karger --- src/openvpn/tls_crypt.c | 30 ++-