Re: [Openvpn-devel] [PATCH 1/1] Rework mbedtls CRL handling

2021-04-08 Thread Antonio Quartulli
Hi Max, I was starting to comment to the various points in this email, but I believe it was getting confusing. Now that I have a better overview (thanks to your explanations!) I would suggest splitting the problem in smaller sub-problems to help our discussion. [Later it'd be very nice to have

Re: [Openvpn-devel] [PATCH 1/1] Rework mbedtls CRL handling

2021-04-08 Thread Maximilian Fillinger
Hi Antonio, Thanks for taking a look! > Mh... I have tried to reproduce this issue, but I was not able to. > Would you be able to provide me with the exact steps to hit this > situation? This bug happens only if the CRL file can't be opened in init_ssl(). (Un-openable CRL files and un-parseable

Re: [Openvpn-devel] [PATCH 1/1] Rework mbedtls CRL handling

2021-04-07 Thread Antonio Quartulli
Hi Max, On 07/04/2021 21:15, Max Fillinger wrote: > This commit fixes the following two issues: > > The config belonging to a mbedtls_ssl_ctx struct is not supposed to be > changed after mbedtls_ssl_setup() has been called. Previously, we > modified the CRL structure in place when a new CRL was

[Openvpn-devel] [PATCH 1/1] Rework mbedtls CRL handling

2021-04-07 Thread Max Fillinger
This commit fixes the following two issues: The config belonging to a mbedtls_ssl_ctx struct is not supposed to be changed after mbedtls_ssl_setup() has been called. Previously, we modified the CRL structure in place when a new CRL was loaded, but a pointer to this struct appears in configs that