Re: [Openvpn-devel] [PATCH 1/3] Make it explicit that WIndows build requires UNICODE support

2021-05-24 Thread Lev Stipakov
Hi, Change makes sense, indeed it was possible to at least try to build iservice in non-UNICODE setup. Which doesn't make much sense since we always build with UNICODE for releases. Built and smoke-tested with MSVC. Haven't noticed any issues. Acked-by: Lev Stipakov __

[Openvpn-devel] [PATCH 1/3] Make it explicit that WIndows build requires UNICODE support

2021-05-21 Thread selva . nair
From: Selva Nair The interactive service code implicitly treats TCHAR == WCHAR in several places with the assumption that we build only with UNICODE defined. Make this explicit and remove some redundant code. Also replace openvpn_sntprintf(), _tprintf() and similar with explicit wide string func