Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2014-05-31 Thread Steffan Karger
ACK (see attached and below for more details). On 03-02-13 14:55, Jan Just Keijser wrote: > Arne Schwabe wrote: >> Am 16.08.12 10:38, schrieb Heiko Hund: >> >>> cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB >>> are used the assertion outlen == iv_len is always false. >>>

Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2013-02-03 Thread Arne Schwabe
Am 03.02.13 14:55, schrieb Jan Just Keijser: > Arne Schwabe wrote: >> Am 16.08.12 10:38, schrieb Heiko Hund: >> >>> cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB >>> are used the assertion outlen == iv_len is always false. >>> >>> There's no CBC mode defined for the GOST

Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2013-02-03 Thread Jan Just Keijser
Arne Schwabe wrote: Am 16.08.12 10:38, schrieb Heiko Hund: cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB are used the assertion outlen == iv_len is always false. There's no CBC mode defined for the GOST 28147-89 block cipher. Hence this patch is needed for it to work.

Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2013-02-02 Thread Arne Schwabe
Am 16.08.12 10:38, schrieb Heiko Hund: > cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB > are used the assertion outlen == iv_len is always false. > > There's no CBC mode defined for the GOST 28147-89 block cipher. Hence > this patch is needed for it to work. It's needed for

[Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2012-08-16 Thread Heiko Hund
cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB are used the assertion outlen == iv_len is always false. There's no CBC mode defined for the GOST 28147-89 block cipher. Hence this patch is needed for it to work. It's needed for other ciphers like BF-CFB as well, though.