Re: [Openvpn-devel] [PATCH 10/12] openvpnmsica, tapctl: Revise default hardware ID management

2020-03-24 Thread Lev Stipakov
Hi, > Since we are getting rid of default hwid, shouldn't we do it also for tapctl > and > make "tapctl list" return all adapters? This is fixed in 12/12. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

Re: [Openvpn-devel] [PATCH 10/12] openvpnmsica, tapctl: Revise default hardware ID management

2020-03-24 Thread Lev Stipakov
Hi, Since we are getting rid of default hwid, shouldn't we do it also for tapctl and make "tapctl list" return all adapters? Since it defaults to root\tap0901, "tapctl list" doesn't show anything for me, which is a bit confusing: > c:\Users\lev\Projects\openvpn\x64-Output\Debug>tapctl.exe list

[Openvpn-devel] [PATCH 10/12] openvpnmsica, tapctl: Revise default hardware ID management

2020-03-09 Thread Simon Rozman
tap_create_adapter() and tap_list_adapter() no longer default to "root\tap0901". Defining a default hardware ID value is at the responsibility of upper layers that process user desires. Since the tap_list_adapter() no longer defaults the hardware ID to anything, its behavior was simplified to