Hi,
> To summarize: the return value of find_adapters() call is ignored on purpose.
Shouldn't return type be void if return value is not used?
I'll ack it to not to further delay 2.5 release, but it would be good
to get a follow-up
patch with either void or return value being not ignored.
Acked
call is ignored on purpose.
Regards,
Simon
-Original Message-
From: Lev Stipakov
Date: Tuesday, 24 March 2020 at 13:07
To: Simon Rozman
Cc: "openvpn-devel@lists.sourceforge.net"
Subject: Re: [Openvpn-devel] [PATCH 11/12] openvpnmsica: Merge
FindTUNTAPAdapters into Find
Hi,
Compiled with msvc, smoke-tested with rundll32.
One thing:
> +set_openvpnserv_state(hInstall);
> +find_adapters(
> +hInstall,
> +TEXT("root\\") TEXT(TAP_WIN_COMPONENT_ID),
> +TEXT("TAPWINDOWS6ADAPTERS"),
> +TEXT("ACTIVETAPWINDOWS6ADAPTERS"));
Both met
1. We don't need two custom actions to evaluate the system state, do we?
2. FindTUNTAPAdapters was actually broken. It enumerated all existing
network adapters, rather than just the ones we are interested in:
TAP-Windows6 and Wintun.
3. TUNTAPADAPTER and ACTIVETUNTAPADAPTERS were split into
