Re: [Openvpn-devel] [PATCH 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread Gert Doering
Hi, On Fri, Jan 13, 2023 at 06:57:54PM -0500, selva.n...@gmail.com wrote: > Use a unified logging format for various route-methods This generally looks good, but I could't get Lev to test it, because the patch does not apply anymore - v2 of the RTA_ macro patch brought "bool ret = ..." change

[Openvpn-devel] [PATCH 2/2] Cleanup route error and debug logging on Windows

2023-01-13 Thread selva . nair
From: Selva Nair Use a unified logging format for various route-methods - Route add/delete errors are always logged with M_WARN, so log only additional information (succeed/exists) with D_ROUTE. - Non-windows platforms log route errors with a prefix "ERROR:" and debug info with "ROUTE:".