Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c

2023-02-25 Thread Gert Doering
Hi, On Sat, Feb 25, 2023 at 12:23:42PM -0500, Selva Nair wrote: > > OTOH, there might be a bit of polishing needed - the other tests > > print out what they are doing ("Running 7 test(s)"), while the > > cryptoapi unit test "just succeeds". Is there something missing > > wrt cmocka initalization?

Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c

2023-02-25 Thread Selva Nair
Hi On Sat, Feb 25, 2023 at 11:29 AM Gert Doering wrote: > Acked-by: Gert Doering > > Thanks for the v4. This enabled me to just push to GH to have > to build and run the tests, without having to bother myself with > copying binaries around :-) > > OTOH, there might be a bit of polishing needed

[Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c

2023-02-25 Thread Gert Doering
Acked-by: Gert Doering Thanks for the v4. This enabled me to just push to GH to have to build and run the tests, without having to bother myself with copying binaries around :-) OTOH, there might be a bit of polishing needed - the other tests print out what they are doing ("Running 7 test(s)")