Re: [Openvpn-devel] [PATCH v2] Add deferred authentication support to plugin-auth-pam

2020-07-14 Thread Gert Doering
Hi, On Tue, Jul 14, 2020 at 01:47:06PM -0400, Selva Nair wrote: > Sorry for the long delay in getting back to this.. A few minor > nitpicks on style follows: Thanks for the review. Indeed, my style fu was sort of absent when I wrote this :-) (it's "mgetty+sendfax" style, with "I must remember to

Re: [Openvpn-devel] [PATCH v2] Add deferred authentication support to plugin-auth-pam

2020-07-14 Thread Selva Nair
Hi, Sorry for the long delay in getting back to this.. A few minor nitpicks on style follows: On Tue, Jun 23, 2020 at 5:29 AM Gert Doering wrote: > > If OpenVPN signals deferred authentication support (by setting > the internal environment variables "auth_control_file" and > "deferred_auth_pam")

[Openvpn-devel] [PATCH v2] Add deferred authentication support to plugin-auth-pam

2020-06-23 Thread Gert Doering
If OpenVPN signals deferred authentication support (by setting the internal environment variables "auth_control_file" and "deferred_auth_pam"), do not wait for PAM stack to finish. Instead, the privileged PAM process returns RESPONSE_DEFER via the control socket, which gets turned into OPENVPN_PLU