Re: [Openvpn-devel] [PATCH v2] Enable stricter compiler warnings by default

Hi, On Thu, Feb 01, 2018 at 07:34:44AM +0100, Steffan Karger wrote: > > Just one thing: if we support compilers other than gcc/clang (say, > > xlc) this would need a test like AX_CHECK_COMPILE_FLAG(). > > Hm, I don't think we do for configure.ac. We do sort-of support MSVC, > but that doesn't

Re: [Openvpn-devel] [PATCH v2] Enable stricter compiler warnings by default

Hi, On 27-01-18 17:47, Selva Nair wrote: > As this is added by default (not in response to --enable/--disable > directives), may be better to prepend to user's CFLAGS? I'm not sure > what the standard practice is, though.. Considering the complexity of > configury, preserving user's input is

Re: [Openvpn-devel] [PATCH v2] Enable stricter compiler warnings by default

Hi, On Fri, Jan 26, 2018 at 5:58 AM, Steffan Karger wrote: > This by default enables the compiler warnings one could previously > enable using the --enable-strict configure option. I think it is > okay to do so now, because we've taken care of many warnings in the > more

[Openvpn-devel] [PATCH v2] Enable stricter compiler warnings by default

This by default enables the compiler warnings one could previously enable using the --enable-strict configure option. I think it is okay to do so now, because we've taken care of many warnings in the more standard builds. (Most of those were totally harmless, but they prevented us from spotting