Re: [Openvpn-devel] [PATCH v2] Handle connecting clients without NCP or OCC without crashing.

2020-07-13 Thread Arne Schwabe
Am 13.07.20 um 11:32 schrieb Gert Doering: > ssl_ncp.c:ncp_get_best_cipher() would crash if a client connects without > NCP (or with a NCP cipher list that does not contain the first NCP cipher > in the server list) due to a NULL pointer strcmp(). > > Work around / fix by just assigning an empty

[Openvpn-devel] [PATCH v2] Handle connecting clients without NCP or OCC without crashing.

2020-07-13 Thread Gert Doering
ssl_ncp.c:ncp_get_best_cipher() would crash if a client connects without NCP (or with a NCP cipher list that does not contain the first NCP cipher in the server list) due to a NULL pointer strcmp(). Work around / fix by just assigning an empty string to remote_cipher here ("not NULL but will