Re: [Openvpn-devel] [PATCH v2] crypto: unify key_type creation code

2022-02-17 Thread Gert Doering
Hi, On Thu, Feb 17, 2022 at 03:32:41PM +0100, Antonio Quartulli wrote: > At the moment we have tls_crypt_kt() and auth_token_kt that basically do > the same thing, but with different algorithms used to inizialise the > structure. > > In order to avoid code duplication and copy/paste errors,

Re: [Openvpn-devel] [PATCH v2] crypto: unify key_type creation code

2022-02-17 Thread Arne Schwabe
Am 17.02.22 um 15:32 schrieb Antonio Quartulli: At the moment we have tls_crypt_kt() and auth_token_kt that basically do the same thing, but with different algorithms used to inizialise the structure. Should be initialise or initialize depending on your dialect. In order to avoid code

[Openvpn-devel] [PATCH v2] crypto: unify key_type creation code

2022-02-17 Thread Antonio Quartulli
At the moment we have tls_crypt_kt() and auth_token_kt that basically do the same thing, but with different algorithms used to inizialise the structure. In order to avoid code duplication and copy/paste errors, unify code and make it parametric, so that it can be re-used in various places.