Re: [Openvpn-devel] [PATCH v2] tapctl: generate driver-specific adapter names

2023-05-19 Thread Lev Stipakov
Hi, > It looks much simpler to write the above 5 lines as > > _stprintf_s(name, name_len, TEXT("%ls #%d"), base_name, i) Agreed. > If (adapter_name) is false, we reach here with iResult not set, but it gets > referenced below. Add an else { iResult = 1; } or initialize iResult to 1 at > top?

Re: [Openvpn-devel] [PATCH v2] tapctl: generate driver-specific adapter names

2023-05-18 Thread Selva Nair
Hi, On Thu, May 18, 2023 at 12:25 PM Lev Stipakov wrote: > From: Lev Stipakov > > At the moment if --name is not specified, adapter names > are generated by Windows and they look a bit confusing > like "Local Area Connection 2". > > This is also behavior of "Add a new virtual network > adapter

[Openvpn-devel] [PATCH v2] tapctl: generate driver-specific adapter names

2023-05-18 Thread Lev Stipakov
From: Lev Stipakov At the moment if --name is not specified, adapter names are generated by Windows and they look a bit confusing like "Local Area Connection 2". This is also behavior of "Add a new virtual network adapter" shortcuts. This makes tapctl generate driver-specific names for adapter