Re: [Openvpn-devel] [PATCH v2 07/11] Refactor extract_var_peer_info into standalone function and add ssl_util.c

2021-02-14 Thread Gert Doering
Hi, On Mon, Jan 25, 2021 at 01:56:24PM +0100, Arne Schwabe wrote: > Our "natural" place for this function would be ssl.c but ssl.c has a lot of > dependencies on all kinds of other compilation units so including ssl.c into > unit tests is near impossible currently. Instead create a new file

Re: [Openvpn-devel] [PATCH v2 07/11] Refactor extract_var_peer_info into standalone function and add ssl_util.c

2021-01-29 Thread Lev Stipakov
Hi, > Patch v2: add newline add the end of sll_util.h and ssl_util.c sll -> ssl Compared to v1, only changes are added newlines. Compiled with MSVC. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

[Openvpn-devel] [PATCH v2 07/11] Refactor extract_var_peer_info into standalone function and add ssl_util.c

2021-01-25 Thread Arne Schwabe
Our "natural" place for this function would be ssl.c but ssl.c has a lot of dependencies on all kinds of other compilation units so including ssl.c into unit tests is near impossible currently. Instead create a new file ssl_util.c that holds small utility functions like this one. Patch v2: add