Re: [Openvpn-devel] [PATCH v3] Fix best gateway selection over netlink

2020-09-11 Thread Vladislav Grishenko
Hi, Antonio Thank you for review -- Best Regards, Vladislav Grishenko > -Original Message- > From: Antonio Quartulli > Sent: Thursday, September 10, 2020 2:02 PM > To: Vladislav Grishenko ; openvpn- > de...@lists.sourceforge.net > Subject: Re: [Openvpn-devel] [PATCH v3

Re: [Openvpn-devel] [PATCH v3] Fix best gateway selection over netlink

2020-09-10 Thread Antonio Quartulli
Hi, On 08/09/2020 14:36, Vladislav Grishenko wrote: > Netlink route request with NLM_F_DUMP flag set means to return > all entries matching criteria passed in message content - > matching supplied family & dst address in our case. > So, gateway from the first ipv4 route was always used. > > On ke

Re: [Openvpn-devel] [PATCH v3] Fix best gateway selection over netlink

2020-09-08 Thread Antonio Quartulli
Hi, On 08/09/2020 15:08, David Sommerseth wrote: > On 08/09/2020 14:36, Vladislav Grishenko wrote: >> On kernels earlier than 2.6.38 default routes are the last ones, >> so arbitrary host/net route w/o gateway is likely be returned as >> first, causing gateway to be invalid or empty. >> After refa

Re: [Openvpn-devel] [PATCH v3] Fix best gateway selection over netlink

2020-09-08 Thread David Sommerseth
On 08/09/2020 14:36, Vladislav Grishenko wrote: > On kernels earlier than 2.6.38 default routes are the last ones, > so arbitrary host/net route w/o gateway is likely be returned as > first, causing gateway to be invalid or empty. > After refactoring in 2.6.38 kernel default routes are on top, so >

[Openvpn-devel] [PATCH v3] Fix best gateway selection over netlink

2020-09-08 Thread Vladislav Grishenko
Netlink route request with NLM_F_DUMP flag set means to return all entries matching criteria passed in message content - matching supplied family & dst address in our case. So, gateway from the first ipv4 route was always used. On kernels earlier than 2.6.38 default routes are the last ones, so ar