Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-05 Thread Antonio Quartulli
Hi Steffan and thanks for the review, On 06/07/18 04:22, Steffan Karger wrote: >> +struct buffer >> +keyfile_to_buffer(const char *file, int max_size, struct gc_arena *gc) >> +{ >> +size_t size; >> +struct buffer in = alloc_buf_gc(max_size, gc); >> +int fd = platform_open(file,

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-05 Thread Steffan Karger
Hi Antonio, On 05-06-18 10:14, Antonio Quartulli wrote: > In preparation to having tls-auth/crypt keys per connection > block, it is important to ensure that such material is always > reloaded upon SIGUSR1, no matter if `persist-key` was specified > or not. > > This is required because when

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-07-03 Thread Antonio Quartulli
Hi, On 27/06/18 09:50, Antonio Quartulli wrote: > Hi, > > On 27/06/18 05:33, David Sommerseth wrote: >> On 05/06/18 10:14, Antonio Quartulli wrote: >>> In preparation to having tls-auth/crypt keys per connection >>> block, it is important to ensure that such material is always >>> reloaded upon

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-06-26 Thread Antonio Quartulli
Hi, On 27/06/18 05:33, David Sommerseth wrote: > On 05/06/18 10:14, Antonio Quartulli wrote: >> In preparation to having tls-auth/crypt keys per connection >> block, it is important to ensure that such material is always >> reloaded upon SIGUSR1, no matter if `persist-key` was specified >> or

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-06-26 Thread David Sommerseth
On 05/06/18 10:14, Antonio Quartulli wrote: > In preparation to having tls-auth/crypt keys per connection > block, it is important to ensure that such material is always > reloaded upon SIGUSR1, no matter if `persist-key` was specified > or not. Has this been tested with --chroot and

Re: [Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-06-24 Thread Antonio Quartulli
Hi, On 05/06/18 16:14, Antonio Quartulli wrote: > In preparation to having tls-auth/crypt keys per connection > block, it is important to ensure that such material is always > reloaded upon SIGUSR1, no matter if `persist-key` was specified > or not. > > This is required because when moving from

[Openvpn-devel] [PATCH v3 1/2] crypto: always reload tls-auth/crypt key contexts

2018-06-05 Thread Antonio Quartulli
In preparation to having tls-auth/crypt keys per connection block, it is important to ensure that such material is always reloaded upon SIGUSR1, no matter if `persist-key` was specified or not. This is required because when moving from one remote to the other the key may change and thus the key