Re: [Openvpn-devel] [PATCH v4 2/3] plug-ins: Disallow multiple deferred authentication plug-ins

2022-03-15 Thread Frank Lichtenheld
> Antonio Quartulli hat am 15.03.2022 16:11 geschrieben: > Frank reported that we should use double space after the full-stop. > Honestly I'd prefer just single-space everywhere as it is more > "traditional". Yeah, I also prefer one space but I actually grepped the code and while it is

Re: [Openvpn-devel] [PATCH v4 2/3] plug-ins: Disallow multiple deferred authentication plug-ins

2022-03-15 Thread Antonio Quartulli
Hi, On 13/03/2022 20:31, David Sommerseth wrote: From: David Sommerseth The plug-in API in OpenVPN 2.x is not designed for running multiple deferred authentication processes in parallel. The authentication results of such configurations are not to be trusted. For now we bail out when this

Re: [Openvpn-devel] [PATCH v4 2/3] plug-ins: Disallow multiple deferred authentication plug-ins

2022-03-14 Thread Frank Lichtenheld
> David Sommerseth hat am 13.03.2022 20:31 > geschrieben: > diff --git a/src/openvpn/plugin.c b/src/openvpn/plugin.c > index e3a89293..8236e29e 100644 > --- a/src/openvpn/plugin.c > +++ b/src/openvpn/plugin.c > @@ -802,7 +802,7 @@ plugin_call_ssl(const struct plugin_list *pl, > const

[Openvpn-devel] [PATCH v4 2/3] plug-ins: Disallow multiple deferred authentication plug-ins

2022-03-13 Thread David Sommerseth
From: David Sommerseth The plug-in API in OpenVPN 2.x is not designed for running multiple deferred authentication processes in parallel. The authentication results of such configurations are not to be trusted. For now we bail out when this discovered with an error in the log. CVE: 2022-0547