Re: [Openvpn-devel] [PATCH v4 6/7] options: enable IPv4 redirection logic only if really required

2020-06-08 Thread Gert Doering
Hi, On Sun, Jun 07, 2020 at 01:25:01PM +0200, Gert Doering wrote: > Can we make this conditional in a way that does not break "redirect-private"? A very simple patch would be if (streq(p[0], "redirect-gateway")) { options->routes->flags |= RG_REROUTE_GW; } +

Re: [Openvpn-devel] [PATCH v4 6/7] options: enable IPv4 redirection logic only if really required

2020-06-07 Thread Gert Doering
Hi, On Sat, May 30, 2020 at 02:05:59AM +0200, Antonio Quartulli wrote: > From: Antonio Quartulli > > If no IPv4 redirection flag is set, do not enable the IPv4 > redirection logic at all so that it won't bother adding any > useless IPv4 route. > > Trac: #208 > Signed-off-by: Antonio Quartulli

[Openvpn-devel] [PATCH v4 6/7] options: enable IPv4 redirection logic only if really required

2020-05-29 Thread Antonio Quartulli
From: Antonio Quartulli If no IPv4 redirection flag is set, do not enable the IPv4 redirection logic at all so that it won't bother adding any useless IPv4 route. Trac: #208 Signed-off-by: Antonio Quartulli --- Changes from v4: - move error message modification to previous patch Changes from