Re: [Openvpn-devel] [PATCH v5 10/14] client-connect: Move adding inotify watch into its own function

2020-07-15 Thread Antonio Quartulli
Hi, On 11/07/2020 11:36, Arne Schwabe wrote: > This make the code a bit better readable and also prepares resuing > the function for client-connect return files > > Signed-off-by: Arne Schwabe This patch looks good and does what it says. No functional change is implemented, but it's all about

Re: [Openvpn-devel] [PATCH v5 10/14] client-connect: Move adding inotify watch into its own function

2020-07-13 Thread tincanteksup
On 11/07/2020 10:36, Arne Schwabe wrote: This make the code a bit better readable and also prepares resuing resuing -> reusing (Don't ask me why this is not re-using, which is how I would probably spell it and my teacher would laugh at me) Grammar: This make the code more readable the

[Openvpn-devel] [PATCH v5 10/14] client-connect: Move adding inotify watch into its own function

2020-07-11 Thread Arne Schwabe
This make the code a bit better readable and also prepares resuing the function for client-connect return files Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git