Re: [Openvpn-devel] discussion: get rid of useless HAVE_* tests

2012-03-23 Thread Alon Bar-Lev
Hello Gert, There are a lot of extra cleanups to do in code. I left this as-is as I have some thoughts of further work on platform.c, like splitting it into its own library. The problem is to support the loggings, need to allocate some time to properly integrate that. So please wait with this o

[Openvpn-devel] discussion: get rid of useless HAVE_* tests

2012-03-23 Thread Gert Doering
Hi, reviewing some of the build patches, I found tests like #ifdef HAVE_CHDIR or #ifdef HAVE_GETPID ... which is craziness. All platforms OpenVPN runs on (except for WIN32) are fully POSIX compliant, and those are all required to have these functions - so testing for them, and having special