Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-08 Thread Samuli Seppänen
This probably makes sense, lots of good refactorings. That said, I'd like to know how you selected what goes to platform.c? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > + Some fixups within the platform.c functions. > - need to check environment se

Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-08 Thread Alon Bar-Lev
Well, at first I wanted to split it into its own libplatform distinct from libcompat. libcompat - emulation of missing library functions, drop-in replacement. libplatform - extensions to library functions, such as unicode or security additions. But then I've seen that there is too much openvpn sp

Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-09 Thread Samuli Seppänen
Thanks for the clarifications! I like the idea of moving some functionality into more general-purpose libraries whenever possible. Those libraries could then be - at least theoretically - used by other projects, so that the code gets more exposure and testing, as well as taking some of the maintena

Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-23 Thread Gert Doering
Hi, On Fri, Mar 09, 2012 at 10:24:30AM +0200, Samuli Seppänen wrote: > I give this one a feature-ACK, but could somebody else take a better > look at the actual code changes? code ACK. Verified that code is just moved + function names renamed, and in a few places, parts of functions moved to a n