Re: [Openvpn-devel] [PATCH v3 1/3] Add remote-count and remote-entry query via management

2022-12-27 Thread Gert Doering
Hi, On Mon, Dec 26, 2022 at 05:30:23PM -0500, Selva Nair wrote: > > > + > > > +#define min(a,b) ((a) < (b) ? (a) : (b)) > > > > We already have min_int and min_uint in integer.h. For consistency I > > would prefer using those instead of adding a macro. Unfortunately, this is more than "just an ex

Re: [Openvpn-devel] [PATCH v3 1/3] Add remote-count and remote-entry query via management

2022-12-26 Thread Selva Nair
Hi On Mon, Dec 26, 2022 at 2:45 PM Arne Schwabe wrote: > Am 08.09.21 um 00:31 schrieb selva.n...@gmail.com: > > From: Selva Nair > > > > Selecting the remote host via the management iterface > > *sigh* I reviewed the v2 instead of the v3 but the typo is still here :P > > > +static void > > +man

Re: [Openvpn-devel] [PATCH v3 1/3] Add remote-count and remote-entry query via management

2022-12-26 Thread Arne Schwabe
Am 08.09.21 um 00:31 schrieb selva.n...@gmail.com: From: Selva Nair Selecting the remote host via the management iterface *sigh* I reviewed the v2 instead of the v3 but the typo is still here :P +static void +man_remote_entry_count(struct management *man) +{ +unsigned count = 0; +if