[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update May 2025

2025-05-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1001?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: Dependency and Actions update May 2025 ...

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency and Actions update May 2025

2025-05-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1001?usp=email ) Change subject: GHA: Dependency and Actions update May 2025 .. GHA: Dependency and Actions update May 2025 chore(deps): update dependency

[Openvpn-devel] [PATCH applied] Re: GHA: Dependency and Actions update May 2025

2025-05-18 Thread Gert Doering
GHA and renovate stuff... no code changes, not directly related to release building. So "push to my GH repository and it builds fine" is all testing I did. Your patch has been applied to the master branch. commit b33aaa6c8371c65c56e372855444d50b28f333e5 Author: Frank Lichtenheld Date: Sun May

[Openvpn-devel] [XS] Change in openvpn[master]: Explicit-exit-notify and multisocket interaction

2025-05-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has uploaded a new patch set (#2) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/917?usp=email ) Change subject: Explicit-exit-notify and multisocket interaction

[Openvpn-devel] [PATCH v1] GHA: Dependency and Actions update May 2025

2025-05-18 Thread Gert Doering
From: OpenVPN Renovate chore(deps): update dependency aws/aws-lc to v1.51.2 chore(deps): update github actions chore(deps): update dependency libressl/portable to v4.1.0 chore(config): migrate config renovate.json chore(deps): update vcpkg digest to b12aa38 Change-Id: I515f96c99f92ba144b60e8504c

[Openvpn-devel] [S] Change in openvpn[master]: Make --dh none behaviour default if not specified

2025-05-18 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/945?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1

[Openvpn-devel] [S] Change in openvpn[master]: Make --dh none behaviour default if not specified

2025-05-18 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/945?usp=email ) Change subject: Make --dh none behaviour default if not specified .

[Openvpn-devel] [S] Change in openvpn[master]: Make --dh none behaviour default if not specified

2025-05-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/945?usp=email ) Change subject: Make --dh none behaviour default if not specified .

[Openvpn-devel] [PATCH v4] Make --dh none behaviour default if not specified

2025-05-18 Thread Gert Doering
From: Arne Schwabe Nowadays ciphers that are using still DH and not ECDH are rarely chosen as best cipher suite. Our man page even indicates that OpenSSL 1.0.1+ supports ECDH cipher suites. So it does not feel useful to force specifying --dh anymore. Side note: Custom generated Diffie Hellmann p

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE c...

2025-05-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ..

[Openvpn-devel] [XS] Change in openvpn[master]: Explicit-exit-notify and multisocket interaction

2025-05-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/917?usp=email ) Change subject: Explicit-exit-notify and multisocket interaction ...

[Openvpn-devel] [PATCH v2] Explicit-exit-notify and multisocket interaction

2025-05-18 Thread Gert Doering
From: Gianmarco De Gregori Check signals after timeout handling to avoid unusual delay when using explicit-exit-notify. Github: fixes OpenVPN/openvpn#702 Change-Id: Id9dbb4d3c550bd4c13f6ee97e67749686457d9fc Signed-off-by: Gianmarco De Gregori Acked-by: Gert Doering --- This change was review

[Openvpn-devel] [PATCH applied] Re: Explicit-exit-notify and multisocket interaction

2025-05-18 Thread Gert Doering
Does the job :-) - back to 2.6 level wrt "ctrl-c and EEN". The whole event loop looks a bit unsatisfying, though, with checking the signals twice in such a short loop... but I guess this needs much deeper digging. Your patch has been applied to the master branch. commit 565d7cf48120d4394258fc3f2

[Openvpn-devel] [XS] Change in openvpn[master]: Explicit-exit-notify and multisocket interaction

2025-05-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/917?usp=email ) Change subject: Explicit-exit-notify and multisocket interaction .. Explicit-exit-notify and multisocket interaction Check signals after t

[Openvpn-devel] [XS] Change in openvpn[master]: Explicit-exit-notify and multisocket interaction

2025-05-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/917?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Explicit-exit-notify and multisocket interaction .