Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread Mirko Vogt
Applied in 32017 - thanks! On 05/31/2012 07:12 PM, Moritz Warning wrote: > Mirko is right, my patch creates a memory leak. > I've attached an alternative patch as proposal. > > Btw., I've send the nodogsplash maintainer a mail a year ago but got no reply > (patch for a minor issue). > > On 05/3

Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread Moritz Warning
Mirko is right, my patch creates a memory leak. I've attached an alternative patch as proposal. Btw., I've send the nodogsplash maintainer a mail a year ago but got no reply (patch for a minor issue). On 05/31/2012 03:21 PM, Outback Dingo wrote: > On Thu, May 31, 2012 at 8:09 AM, Mirko Vogt wro

[OpenWrt-Devel] [PATCH] Fix extroot by UUID

2012-05-31 Thread jarek1701
Extroot works fine when the target device is specified by a path. It fails however if the device is specified by UUID (the target partition gets mounted much later by hotplug hooks). This is because the blkid command is no longer compiled into BusyBox (since changeset [1]) so it's unavailable fo

Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread Outback Dingo
On Thu, May 31, 2012 at 8:09 AM, Mirko Vogt wrote: > The project isn't really maintained anymore, but it's definitely worth a > try getting a fix upstream. > The patch applies and is working, however I wonder whether it creates a > memleak, since strdup is called which allocates memory which doesn

Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread Mirko Vogt
The project isn't really maintained anymore, but it's definitely worth a try getting a fix upstream. The patch applies and is working, however I wonder whether it creates a memleak, since strdup is called which allocates memory which doesn't get free'ed again. On 05/31/2012 11:33 AM, John Crispin

[OpenWrt-Devel] Unrecognized 96328avng board with trunk brcm63xx r32004

2012-05-31 Thread Vince Huang
First thanks jogo for adding support for bcm 96328avng board.But my 96328avng board is still unrecognized with trunk updated after r32004. TTL: Build Date: 2010-06-28 15:35:56 (wander@broadcom-eu)CFE version 1.0.37-106.17-1 for BCM96328 (32bit,SP,BE) Copyright (C) 2000-2009 Broadcom Corporat

[OpenWrt-Devel] Fwd: [OpenWrt-Commits] r32015 - packages/libs/pthsem

2012-05-31 Thread Michael Markstaller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hmm, pthsem builds and works fine here an ar71xx without eglibc. There was another problem with kernel 3.x which is fixed upstream in git already and I sent a patch a while back: https://lists.openwrt.org/pipermail/openwrt-devel/2011-October/012567.ht

Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread John Crispin
On 31/05/12 11:23, Moritz Warning wrote: > Sorry, I wasn't very specific; nodogsplash exits rather than crashing. > It uses a safe_strdup call that exits in this case. > That still makes it a remote DoS exploit :-) ___ openwrt-devel mailing list openwrt

Re: [OpenWrt-Devel] Fwd: [PATCH] nodogsplash crashes when rdir parameter is missing

2012-05-31 Thread Moritz Warning
Sorry, I wasn't very specific; nodogsplash exits rather than crashing. It uses a safe_strdup call that exits in this case. On 05/31/2012 08:46 AM, John Crispin wrote: > CC'ing the nodogsplash people ... could they comment on the patch ? > looks like a remote DoS exploit > > > > Or

Re: [OpenWrt-Devel] About the new netifd infrastructure

2012-05-31 Thread Roberto Riggio
On 05/30/2012 04:09 PM, Felix Fietkau wrote: Do you have any call to proto_init_update/proto_send_update in there, similar to what the dhcp script does when it has acquired a lease? Hi, thanks for the feedback. I'm making some progresses now. This is the current script: #!/bin/sh [ -n "$INC