Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf

2012-12-03 Thread Felix Fietkau
On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking the pointer argument is undefined. Please

Re: [OpenWrt-Devel] [PATCH 7/7] [package] uci: Alternate dir for uci_get and friends

2012-12-03 Thread Felix Fietkau
On 2012-11-13 11:43 PM, Daniel Dickinson wrote: On 10/11/2012 8:35 AM, Felix Fietkau wrote: On 2012-11-09 11:10 PM, Daniel Dickinson wrote: --- package/uci/files/lib/config/uci.sh |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/uci/files/lib/config/uci.sh

Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf

2012-12-03 Thread Frank Meerkötter
On 03/12/12 10:43, Felix Fietkau wrote: On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking the

[OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Frank Meerkötter
Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null byte among the first n bytes of src, the string

Re: [OpenWrt-Devel] [PATCH][package] make ltq-dsl-app compile with an eglibc-based toolchain

2012-12-03 Thread Mirko Vogt
On 11/22/2012 10:22 AM, Frank Meerkötter wrote: Hi, i had problems building the ltq-dsl-app when switching from uclibc to eglibc. This patch is adding a needed include, adds a configure test to figure out where clock_gettime() is located and runs autoreconfigurer afterwards. Please

Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Florian Fainelli
On Monday 03 December 2012 13:42:23 Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If

Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Felix Fietkau
On 2012-12-03 1:42 PM, Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null

Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf

2012-12-03 Thread Felix Fietkau
On 2012-12-03 1:21 PM, Frank Meerkötter wrote: On 03/12/12 10:43, Felix Fietkau wrote: On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not

Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Frank Meerkötter
On 03/12/12 13:56, Felix Fietkau wrote: On 2012-12-03 1:42 PM, Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread Paul Fertser
Hi, Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread Aaron Z
Paul Fertser fercer...@gmail.com wrote: Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our

[OpenWrt-Devel] [PATCH] fix error checking of asprintf

2012-12-03 Thread Frank Meerkötter
see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp is undefined. Signed-off-by:

Re: [OpenWrt-Devel] [PATCH] fix error checking of asprintf

2012-12-03 Thread Felix Fietkau
On 2012-12-03 7:29 PM, Frank Meerkötter wrote: see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1,

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread John Lauro
That's how I read it too. You are assuming you would catch it, and know what is causing it... Might be subtle enough that it just looks like an google ranked ad. (I would probably not notice, as I tend to always vpn back to home servers and vpn back for even general internet traffic despite

[OpenWrt-Devel] [PATCH] ramips: Add support for Hauppauge Broadway

2012-12-03 Thread Devin Heitmueller
From: Devin Heitmueller dheitmuel...@kernellabs.com This patch introduces OpenWRT support for the base Hauppauge/PCTV Broadway platform. It doesn't deal with the TV tuner or transcoder at this point, but the core functionality is working (Ethernet, wireless, USB, buttons, LEDs, etc).

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread Brian Epstein
You hit the nail on the head. Occasional modification of searches in exchange for free Internet at hotels. -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of John Lauro Sent: Monday, December 03, 2012 4:41 PM To: OpenWrt Development

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread Ben West
Although the general idea is certainly valid, and even though Open-Mesh.com is on-board, I would recommend doing to some research about whether Google itself might find issue with 3rd parties intercepting and modifying users' search queries sent to google.com. Especially since this has now been

Re: [OpenWrt-Devel] how add 'print' to /usr/lib/lua/luci/model/uci.lua??

2012-12-03 Thread Petr Štetiar
. Elvis szx7...@gmail.com [2012-12-03 10:28:25]: Hi all, when i add above 'print(hello)' in /usr/lib/lua/luci/model/uci.lua You need to define it first at the top of the file: diff --git a/libs/core/luasrc/model/uci.lua b/libs/core/luasrc/model/uci.lua index

Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code

2012-12-03 Thread David Bird
I believe the key is to give the visitor/user notice... so they know their searches are being weighted toward a location/retailer and can decide if that is something worth the free access. I don't think it is any more 'man in the middle' as Google itself or in violation of any terms of service

Re: [OpenWrt-Devel] how add 'print' to /usr/lib/lua/luci/model/uci.lua??

2012-12-03 Thread . Elvis
thank you ynezz!! elvis 2012/12/4 Petr Štetiar yn...@true.cz . Elvis szx7...@gmail.com [2012-12-03 10:28:25]: Hi all, when i add above 'print(hello)' in /usr/lib/lua/luci/model/uci.lua You need to define it first at the top of the file: diff --git

Re: [OpenWrt-Devel] [PATCH] ramips: Add support for Hauppauge Broadway

2012-12-03 Thread John Crispin
On 03/12/12 23:23, Devin Heitmueller wrote: From: Devin Heitmueller dheitmuel...@kernellabs.com This patch introduces OpenWRT support for the base Hauppauge/PCTV Broadway platform. It doesn't deal with the TV tuner or transcoder at this point, but the core functionality is working (Ethernet,