Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread Jo-Philipp Wich
Hi, comments inline dito. On 12/04/2015 03:56, Luka Perkov wrote: Signed-off-by: Luka Perkov l...@openwrt.org --- changes in v2: * no need to null-terminate string after sprintf() file.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/file.c

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread Felix Fietkau
On 2015-04-14 17:41, John Crispin wrote: hi comments inline On 13/04/2015 02:34, Luka Perkov wrote: The base code has been taken from zstream project which was written by Steven Barth. Signed-off-by: Luka Perkov l...@openwrt.org CC: Steven Barth ste...@midlink.org --- --- /dev/null

[OpenWrt-Devel] [PATCH] hostapd: Fix wps button hotplug script to handle multiple radios

2015-04-14 Thread Hannu Nyman
Hostapd's control file location was changed in 2013, and that has apparently broken the wps button hotplug script in cases where there are multiple radios and wps is possibly configured also for the second radio. The current wps button hotplug script always handles only the first radio.

Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread John Crispin
hi, comments inline On 12/04/2015 03:56, Luka Perkov wrote: Signed-off-by: Luka Perkov l...@openwrt.org --- changes in v2: * no need to null-terminate string after sprintf() file.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/file.c

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
with these patches applied none of the 4MB image build ?! /openwrt/trunk/staging_dir/host/bin/mktplinkfw -H 0x00100101 -W 0x1 -F 4Mlzma -N OpenWrt -V r45435 -k /openwrt/trunk/build_dir/target-mips_34kc_uClibc-0.9.33.2/linux-ar71xx_generic/vmlinux-initramfs -r

Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread John Crispin
[...] + if (!S_ISREG(s.st_mode)) + return UBUS_STATUS_NOT_SUPPORTED; should this not be - UBUS_STATUS_INVALID_ARGUMENT I think not supported in response to md5sum of a non-regular file (like a chardev or directory) makes sense here - imho. your codebase, so your call :-)

Re: [OpenWrt-Devel] [Patch] wpan: rework bluetooth / wpan and 6lowpan dependencies

2015-04-14 Thread John Crispin
Hi Dirk, patch does not apply anymore, could you send a rebased version please John On 10/04/2015 18:35, Dirk Neukirchen wrote: Is there a reason for Kernel 4.0 as all the modules already exist in 3.18 - fix: lines are doubled - fix: 6lowpan symbol integrated into a bluetooth

Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread Jo-Philipp Wich
Ok, ACK from me then. Thanks for taking care of the merge. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread John Crispin
hi comments inline On 13/04/2015 02:34, Luka Perkov wrote: The base code has been taken from zstream project which was written by Steven Barth. Signed-off-by: Luka Perkov l...@openwrt.org CC: Steven Barth ste...@midlink.org --- = changes in v2: Use new API: size_t b64decode(void

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread Luka Perkov
Hi, On Tue, Apr 14, 2015 at 06:00:32PM +0200, Felix Fietkau wrote: + if (data[len - 1] == '=') + ret--; + + if (data[len - 2] == '=') + ret--; the 2 if clauses look redundant and i guess you could solve it with a loop Ok. I'll fix it. I'd prefer not passing

Re: [OpenWrt-Devel] [PATCH V2] b53: override CPU port state on BCM5301X with CPU port other than 8

2015-04-14 Thread Ian Kent
On Sun, 2015-04-12 at 19:01 +0200, Rafał Miłecki wrote: Newer revisions (5+) of BCM53011 and probably all revs of BCM53012 require overriding CPU port to work. So far we were handling it only for CPU port 8, but some devices may use e.g. port 5. In such case we need to use recently defined

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
On 14/04/2015 20:48, Alexander Couzens wrote: Hi John, i'm looking into it. I haven't build these with initramfs. Best, lynxis thanks ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread Alexander Couzens
Hi John, i'm looking into it. I haven't build these with initramfs. Best, lynxis On Tue, 14 Apr 2015 20:17:09 +0200 John Crispin blo...@openwrt.org wrote: with these patches applied none of the 4MB image build ?! /openwrt/trunk/staging_dir/host/bin/mktplinkfw -H 0x00100101 -W 0x1 -F

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread Alexander Couzens
I've found the issue. It was already present on the previous tplink images. The new Build/mktplinkfw step duplicated the rootfs. Once within kernel image and once when using mktplinkfw initramfs. I'll send another patch to this list, but it doesn't touch this patch serie. After taking another

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread Felix Fietkau
On 2015-04-14 18:24, Luka Perkov wrote: Hi, On Tue, Apr 14, 2015 at 06:00:32PM +0200, Felix Fietkau wrote: + if (data[len - 1] == '=') + ret--; + + if (data[len - 2] == '=') + ret--; the 2 if clauses look redundant and i guess you could solve it with a loop

[OpenWrt-Devel] OpenWrt documentation team

2015-04-14 Thread Eric Schultz
All, I'm looking to improve some of the documentation around OpenWrt, particularly related to unique OpenWrt features like jails, procd, uci, etc. Before I go around developing that individually, I think it'd be great to work collaboratively on this with others. Is there OpenWrt have a team

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
On 14/04/2015 21:29, Alexander Couzens wrote: I've found the issue. It was already present on the previous tplink images. The new Build/mktplinkfw step duplicated the rootfs. Once within kernel image and once when using mktplinkfw initramfs. I'll send another patch to this list, but it

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread Jonas Gorski
Hi, On Mon, Apr 13, 2015 at 2:34 AM, Luka Perkov l...@openwrt.org wrote: The base code has been taken from zstream project which was written by Steven Barth. Signed-off-by: Luka Perkov l...@openwrt.org CC: Steven Barth ste...@midlink.org --- = changes in v2: Use new API: size_t

[OpenWrt-Devel] [PATCH] ar71xx/image: remove duplicated rootfs in new tplink initramfs images

2015-04-14 Thread Alexander Couzens
The new building code included the rootfs twice when building tplink initramfs images. To make it more readable move initramfs into an own build step Build/mktplinkfw-initramfs. Signed-off-by: Alexander Couzens lyn...@fe80.eu --- target/linux/ar71xx/image/Makefile | 18 ++ 1

[OpenWrt-Devel] [PATCH] Removed reference to imaginary procd_add_interface_reload in procd.sh

2015-04-14 Thread Eric Schultz
The last line of procd.sh has a reference to procd_add_interface_reload. procd_add_interface_reload doesn't seem to exist. I've removed the reference of it to minimize confusion. Signed-off-by: Eric Schultz eschu...@prplfoundation.org --- package/system/procd/files/procd.sh | 1 - 1 file