[OpenWrt-Devel] RE?? ??????[PATCH]ramips: reset m25p80 when shutdown

2015-11-21 Thread ??????
Reset the flash is not absolutely necessary, this command should reset all the register, but some flash donot exit 4byte address mode with it.Of cause, SPINOR_OP_EX4B is already sufficient to resolve the soft reboot problem, I want to reset every register not only the address mode bit.Well, I wi

Re: [OpenWrt-Devel] 回复:[PATCH] ramips: reset m25p80 when shutdown

2015-11-21 Thread Daniel Golle
On Sat, Nov 21, 2015 at 09:41:25PM +0100, John Crispin wrote: > Hi, > > one more request > > On 16/11/2015 18:03, 未命名 wrote: > > Instead of use the set_4byte function in spi-nor.c, I use this patch > > for simplest modification. In fact, set_4byte also send 0xe9 command to > > the spi flash. Usi

[OpenWrt-Devel] [PATCH v3 5/6] brcm2708: add device detection and use it for network, leds and preinit

2015-11-21 Thread Álvaro Fernández Rojas
Signed-off-by: Álvaro Fernández Rojas --- v3: use new board detection layer v2: device tree model needs Rev to avoid detecting a B+ as a B model target/linux/brcm2708/base-files.mk| 3 ++ .../brcm2708/base-files/etc/board.d/02_network | 25 + target/linux/brcm270

Re: [OpenWrt-Devel] [PATCH] kernel: mtd: Backport GD25Q128B support to 3.18

2015-11-21 Thread Srdjan Rosic
Friendly ping, This is just a single line kernel backport, and I actually have a mt7621 ramips board (ramips is still on 3.18) that uses this 32M flash chip. Thank you, -risk On Tue, Nov 17, 2015 at 10:46 PM, Srdjan Rosic wrote: > Support is present in 3.19 and above as kernel commit: > fcc87a

Re: [OpenWrt-Devel] [PATCH v2] Fix Busybox “uname -o”

2015-11-21 Thread Mark Mentovai
I wrote: OpenWrt’s busybox/config/coreutils/Config.in needs to mirror Busybox’ own coreutils/Config.src. Likely, all of OpenWrt’s busybox Config.in files need to be updated in this way after a Busybox update. I posted this as an alternative, more complete patch, under the title [PATCH] busybo

[OpenWrt-Devel] [PATCH] busybox: Update config for 1.24.1

2015-11-21 Thread Mark Mentovai
r47288 updated to Busybox 1.24.1 but did not update the configuration. The configuration is updated by running cd config ../convert_menuconfig.pl .../build_dir/target-*/busybox-1.24.1 cd .. ./convert_defaults.pl < .../build_dir/target-*/busybox-1.24.1/.config > \ Config-defaults.in Signed-o

Re: [OpenWrt-Devel] [PATCH] Fix Busybox “uname -o”

2015-11-21 Thread Mark Mentovai
John Crispin wrote: patch does not apply to current trunk Sorry, the tabs got swallowed. I re-sent it. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [001/001] TL-WR710N: create image for v2.1

2015-11-21 Thread Norbert Wegener
As git send-email seems to be broken here - permanently "Unable to initialize SMTP properly" , the patch as attachment. Norbert On 21.11.2015 18:38, John Crispin wrote: > Hi, > > the patch is unfortunately line wrapped and whitespace broken. try > sending the patch using "git send-email" > >

[OpenWrt-Devel] [PATCH v2] Fix Busybox “uname -o”

2015-11-21 Thread Mark Mentovai
Since r47288, “uname -o” shows “n”. It used to be “GNU/Linux”. root at gw1 sh# uname -a Linux gw1.nyc 4.1.11 #1 Sat Nov 21 12:50:41 EST 2015 mips n root at gw1 sh# uname -o n It looks like a recent change in Busybox uname made “uname -o” configurable: http://git.busybox.net/busybox/commit?id=6

Re: [OpenWrt-Devel] 回复:[PATCH] ramips: reset m25p80 when shutdown

2015-11-21 Thread John Crispin
Hi, one more request On 16/11/2015 18:03, 未命名 wrote: > Instead of use the set_4byte function in spi-nor.c, I use this patch > for simplest modification. In fact, set_4byte also send 0xe9 command to > the spi flash. > > Signed-off-by: Shonn Lu > --- > .../0064-reset-m25p80-when-shutdown.patch

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: Add support for Wallys DR344

2015-11-21 Thread John Crispin
Hi, Applying: ar71xx: Add support for Wallys DR344 fatal: sha1 information is lacking or useless (target/linux/ar71xx/base-files/etc/diag.sh). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ar71xx: Add support for Wallys DR34

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

2015-11-21 Thread John Crispin
Hi, i had a closer look at the code. what you want to do instead of adding 2 dummy muxes is to modify static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev, and change this part /* mark the pins as gpio */ for (i = 0; i < p->groups[group].func[0].pin_count; i++)

Re: [OpenWrt-Devel] [PATCH] Fix Busybox “uname -o”

2015-11-21 Thread John Crispin
Hi, patch does not apply to current trunk John On 21/11/2015 19:34, Mark Mentovai wrote: > Since r47288, “uname -o” shows “n”. It used to be “GNU/Linux”. > > root@gw1 sh# uname -a > Linux gw1.nyc 4.1.11 #1 Sat Nov 21 12:50:41 EST 2015 mips n > root@gw1 sh# uname -o > n > > It looks lik

Re: [OpenWrt-Devel] [PATCH] kernel/generic: 3.18, 4.y: Add support for Quectel EC20 Mini PCIe module

2015-11-21 Thread John Crispin
Thanks, i dropped the 4.0 part as we dont have that in trunk anymore John On 11/11/2015 14:18, Petr Štetiar wrote: > * both patches (qcserial/qmi_wwan) were submitted upstream[1,2] > * build tested on 3.18 and 4.1 > * run tested on imx6 platform with 4.1 > > 1. http://article.gmane.org/g

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
On 21/11/2015 20:50, Paul Fertser wrote: > Hello, > > John Crispin writes: >> // is c++ >> >> /* this is the c version */ > > Strictly speaking, // is a valid way to add one-line comments since C99. > ok, let me be more precise. the code style of procd forbids this ;) ___

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread Paul Fertser
Hello, John Crispin writes: > // is c++ > > /* this is the c version */ Strictly speaking, // is a valid way to add one-line comments since C99. -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com __

Re: [OpenWrt-Devel] [PATCH v5 5/5] ar71xx: add support for Cisco's MR18

2015-11-21 Thread John Crispin
Hi comments inline On 22/09/2015 19:08, Chris R Blake wrote: > From: Chris R Blake > > This patch adds support for Cisco's MR18. > Detailed instructions for the flashing the device can > be found in the OpenWrt forum thread: > > > Signed-off

Re: [OpenWrt-Devel] [PATCH v5 4/5] ar71xx: add LED driver NU801

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 22/09/2015 19:07, Chris R Blake wrote: > From: Chris R Blake > > The MR18 uses a 3-channel 16-bit PWM Constant Current Driver > for its status LED. > > Signed-off-by: Chris R Blake > --- > package/base-files/files/etc/init.d/led| 2 +- > .../linux/ar71xx

Re: [OpenWrt-Devel] [PATCH v5 2/5] ar71xx: add support for qca955x sgmii/serdes calibration

2015-11-21 Thread John Crispin
Hi, same as on 1/5 the registers are not set in the right part of the code John On 22/09/2015 18:49, Chris R Blake wrote: > From: Chris R Blake > > This patch is to add support for sgmii/serdes calibration from > within the OpenWRT environment. This is needed on boards that > do not us

Re: [OpenWrt-Devel] [PATCH v5 1/5] ar71xx: add eth rx delay for qca955x platforms

2015-11-21 Thread John Crispin
Hi, sorry to jump in this late at a V5 but i have a few concerns. see inline On 22/09/2015 18:49, Chris R Blake wrote: > From: Chris R Blake > > This patch is to add support for qca955x_eth_rx_delay > to work with the qca955x SoC. > > Signed-off-by: Chris R Blake > --- > ...42-MIPS-ath79-add

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread Daniel Gimpelevich
On Sat, 2015-11-21 at 20:19 +0100, John Crispin wrote: > > On 21/11/2015 20:17, Daniel Gimpelevich wrote: > > On Sat, 2015-11-21 at 20:15 +0100, John Crispin wrote: > >> On 21/11/2015 20:05, Daniel Gimpelevich wrote: > >>> On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: > On Sat,

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
On 21/11/2015 20:17, Daniel Gimpelevich wrote: > On Sat, 2015-11-21 at 20:15 +0100, John Crispin wrote: >> On 21/11/2015 20:05, Daniel Gimpelevich wrote: >>> On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: > Hi, > >>

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread Daniel Gimpelevich
On Sat, 2015-11-21 at 20:15 +0100, John Crispin wrote: > On 21/11/2015 20:05, Daniel Gimpelevich wrote: > > On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: > >> On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: > >>> Hi, > >>> > >>> common, you know how to send a patch and put a S

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
On 21/11/2015 20:05, Daniel Gimpelevich wrote: > On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: >> On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: >>> Hi, >>> >>> common, you know how to send a patch and put a SoB under it. i've seen >>> you do it lots of times ;) >>> >>>

Re: [OpenWrt-Devel] [PATCH v2] lantiq: add phy led config support over devicetree bindings

2015-11-21 Thread John Crispin
On 21/11/2015 20:09, Florian Eckert wrote: > Hallo, > > if you mean "CONFIG_OF_MDIO"? I have added this define because if we > have no "openfirmware" a dummy function will be called. Or do you mean > the whole patch? > > Regards > > Flo ah i misread it and did not see the OF_ part. fine in thi

Re: [OpenWrt-Devel] [PATCH v2] lantiq: add phy led config support over devicetree bindings

2015-11-21 Thread Florian Eckert
Hallo, if you mean "CONFIG_OF_MDIO"? I have added this define because if we have no "openfirmware" a dummy function will be called. Or do you mean the whole patch? Regards Flo Am 21.11.2015 6:55 nachm. schrieb "John Crispin" : > > Hi > > 1 comment inline > > On 09/11/2015 13:44, Florian Eckert

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread Daniel Gimpelevich
On Sat, 2015-11-21 at 10:27 -0800, Daniel Gimpelevich wrote: > On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: > > Hi, > > > > common, you know how to send a patch and put a SoB under it. i've seen > > you do it lots of times ;) > > > > John > > Yes, but it just doesn't feel right

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: Add support for Wallys DR344

2015-11-21 Thread Philippe DUCHEIN
Hi John, Sorry for convenience I suppressed it This patch is for Wallys DR344 support under OpenWRT. It’s release 2.1 ChangeLog: suppress suppress blank line insert into target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile Signed-off-by: Phili

Re: [OpenWrt-Devel] [PATCH v2 5/6] brcm2708: add device detection and use it for network, leds and preinit

2015-11-21 Thread Álvaro Fernández Rojas
Sure, I will rework this as soon as I can. Regards, Álvaro. El 21/11/2015 a las 9:45, John Crispin escribió: Hi, do you have time to rework this code to make use of the new board detection layer ? i am currently starting to convert all targets to it. would be a shame if we add this ode just to

[OpenWrt-Devel] [PATCH] Fix Busybox “uname -o”

2015-11-21 Thread Mark Mentovai
Since r47288, “uname -o” shows “n”. It used to be “GNU/Linux”. root@gw1 sh# uname -a Linux gw1.nyc 4.1.11 #1 Sat Nov 21 12:50:41 EST 2015 mips n root@gw1 sh# uname -o n It looks like a recent change in Busybox uname made “uname -o” configurable: http://git.busybox.net/busybox/commit?id=64ed5f0d3c

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread Daniel Gimpelevich
On Sat, 2015-11-21 at 19:15 +0100, John Crispin wrote: > Hi, > > common, you know how to send a patch and put a SoB under it. i've seen > you do it lots of times ;) > > John Yes, but it just doesn't feel right for me to do when the patch is essentially from Joerg and not from me. ___

Re: [OpenWrt-Devel] [RFC] A patch for mt7621 nand controler. Revision 2.

2015-11-21 Thread John Crispin
Hi, ugly patch to make an ugly driver work. i am sure you had a lot of fun debugging this one. thanks ! John On 13/11/2015 08:55, Kirill Berezin wrote: > Hello, > > It turned out that mtk_nand driver uses some sophisticated accounting > and a general nand code must be patched. > > This

Re: [OpenWrt-Devel] [PATCH] Quagga 0.99.23 CISCO EIGRP support

2015-11-21 Thread John Crispin
Hi, package is hosted on github and not part of the core. please send a PR via using github. John On 09/11/2015 03:28, Lucian Cristian wrote: > On 04.11.2015 22:35, Lucian Cristian wrote: >> >> based on git: https://github.com/janovic/Quagga-EIGRP >> tested with opennhrp (gre tunnels, no

Re: [OpenWrt-Devel] [PATCH] [packages] add mt-st package to write to tape devices

2015-11-21 Thread John Crispin
Hi this really belongs into the feed. please submit a PR via github. John On 10/11/2015 12:44, Giuseppe Magnotta wrote: > Add mt-st package in order to write to tape devices > > Signed-off-by: Giuseppe Magnotta > > > diff --git a/package/utils/mt-st

Re: [OpenWrt-Devel] [PATCH] lantiq: spi-max-frequency

2015-11-21 Thread John Crispin
Hi, common, you know how to send a patch and put a SoB under it. i've seen you do it lots of times ;) John On 09/11/2015 20:36, Daniel Gimpelevich wrote: > On Thu, 2015-02-26 at 16:02 +0100, Joerg Jungermann wrote: >> Hi, >> >> I have here multiple TD-W8970 with Annex A and Annex B. >> >

Re: [OpenWrt-Devel] [PATCH v2] [ramips] mt7621: add support for netis WF-2881‏

2015-11-21 Thread John Crispin
Hi, the patch does not apply. is this against trunk or CC ? John On 14/11/2015 15:32, YounJaeRho wrote: > netis WF-2881 is an MT7621AT based router with MT7602EN, MT7612EN. > It has 128MB DDR3, 128MB SLC NAND FLASH, 5-port Gbps switch and 1x USB 3.0. > The following patch adds support fo

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Youku YK1

2015-11-21 Thread John Crispin
Hi 1 comment inline On 08/11/2015 07:08, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > target/linux/ramips/base-files/etc/board.d/01_leds | 5 + > .../linux/ramips/base-files/etc/board.d/02_network | 1 + > target/linux/ramips/base-files/lib/ramips.sh | 3 + > .../ramips/base-fi

Re: [OpenWrt-Devel] [PATCH] oxnas: add some default packages of router

2015-11-21 Thread John Crispin
Hi, On 07/11/2015 21:12, Shonn Lu wrote: > Signed-off-by: Shonn Lu > --- > target/linux/oxnas/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/linux/oxnas/Makefile b/target/linux/oxnas/Makefile > index 32bcab8..87b9489 100644 > --- a/target/linux/oxnas/

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: Add support for Wallys DR344

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 08/11/2015 10:46, Philippe DUCHEIN wrote: > This patch is for Wallys DR344 support under OpenWRT > > Signed-off-by: Philippe DUCHEIN > > — > > diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh > b/target/linux/ar71xx/base-files/etc/diag.sh > --- a/target/linux/ar

Re: [OpenWrt-Devel] [PATCH v2] lantiq: add phy led config support over devicetree bindings

2015-11-21 Thread John Crispin
Hi 1 comment inline On 09/11/2015 13:44, Florian Eckert wrote: > This patch adds the posibility to config the led behaviour of the lantiq phys > over the devicetree bindings.It patches the > 0023-NET-PHY-adds-driver-for-lantiq-PHY11G > for 3.18 and 4.1. I have also added a register description

Re: [OpenWrt-Devel] [PATCH] [001/001] TL-WR710N: create image for v2.1

2015-11-21 Thread John Crispin
Hi, the patch is unfortunately line wrapped and whitespace broken. try sending the patch using "git send-email" John On 17/11/2015 20:41, Norbert Wegener wrote: > This patch just extends target/linux/ar71xx/image/Makefile to build > images also for version 2.1 of TL-WR710N > > diff --gi

Re: [OpenWrt-Devel] [PATCH 2/3] ar71xx: add GL-AR300 support V2

2015-11-21 Thread John Crispin
Hi, 1 comment inline On 17/11/2015 04:37, alzhao wrote: > Add support for GL-AR300 for latest trunk. Tested and works well. > > Signed-off-by: Alzhao > --- > .../ar71xx/base-files/etc/uci-defaults/01_leds | 4 + > .../ar71xx/base-files/etc/uci-defaults/02_network | 6 ++ > target/linu

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx: add GL-AR150 support V2

2015-11-21 Thread John Crispin
Hi comment 1 inline On 17/11/2015 04:37, alzhao wrote: > Added GL-AR150 support to latest trunk. Tested and works good. > > Signed-off-by: Alzhao > --- > .../ar71xx/base-files/etc/uci-defaults/01_leds | 4 + > .../ar71xx/base-files/etc/uci-defaults/02_network | 1 + > target/linux/ar71

Re: [OpenWrt-Devel] API documentation of ubus

2015-11-21 Thread Pratik Prajapati
Thanks Javier. Till now I have referred ubus only, but now I can start reading procd, uhttpd, netifd to have more understanding. On Sat, Nov 21, 2015 at 5:38 PM, Javier Domingo Cansino wrote: > The only documentation you have from ubus is > https://wiki.openwrt.org/doc/techref/ubus > > Apart fr

Re: [OpenWrt-Devel] API documentation of ubus

2015-11-21 Thread Javier Domingo Cansino
The only documentation you have from ubus is https://wiki.openwrt.org/doc/techref/ubus Apart from that, you can read procd, rpcd, uhttpd, netifd and ubus itself to see how to use it. I had plans on further documenting it but still didn't have time. You are welcome to further document it. On Sat,

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
On 21/11/2015 12:06, Etienne Champetier wrote: > Hi, > > first sorry, i've forgot to add the ticket reference > https://dev.openwrt.org/ticket/20785 > > also full disclore, I'm only writing C for OpenWrt > so is there a compilation flag to disable C++, > or can you be more specific on what C++

Re: [OpenWrt-Devel] API documentation of ubus

2015-11-21 Thread Pratik Prajapati
Gentle Reminder On Fri, Nov 20, 2015 at 6:29 PM, Pratik Prajapati < pratik.prajapat...@gmail.com> wrote: > Hi, > > Is there any API documentation of ubus available? > > If yes, where can i found those? > > ___ openwrt-devel mailing list openwrt-devel@li

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread Etienne Champetier
Hi, first sorry, i've forgot to add the ticket reference https://dev.openwrt.org/ticket/20785 also full disclore, I'm only writing C for OpenWrt so is there a compilation flag to disable C++, or can you be more specific on what C++ ism i'm using ? 2015-11-21 9:08 GMT+01:00 John Crispin : > > >

Re: [OpenWrt-Devel] [PATCH v2 5/6] brcm2708: add device detection and use it for network, leds and preinit

2015-11-21 Thread John Crispin
Hi, do you have time to rework this code to make use of the new board detection layer ? i am currently starting to convert all targets to it. would be a shame if we add this ode just to replace it again in a few weeks. John On 19/11/2015 19:18, Álvaro Fernández Rojas wrote: > Signed-off-

Re: [OpenWrt-Devel] [PATCH] Add support for Huawei WS880

2015-11-21 Thread John Crispin
Hi, can you please resend the patch with a proper prefix. in this case "bcm53xx:" John On 20/11/2015 14:06, Prototik wrote: > --- > target/linux/bcm53xx/image/Makefile| 14 +++ > .../910-ARM-BCM5301X-Add-DT-for-Huawei-WS880.patch | 115 > + > .../9

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
On 21/11/2015 00:05, Etienne CHAMPETIER wrote: > Using ldd (via popen()) is a hack, but it's simpler (and working) indeed > we have 3 libc and many archs, too many ways to resolve .so where does it break ? > Current code: > -do not parse the intepreter (PT_INTERP) part of the elf why should i

Re: [OpenWrt-Devel] [PATCH procd 2/2] ujail: rework file dependencies detection (use ldd)

2015-11-21 Thread John Crispin
Hi, can you please convert this to c code ? we dont like c++ patterns John On 21/11/2015 00:05, Etienne CHAMPETIER wrote: > Using ldd (via popen()) is a hack, but it's simpler (and working) > we have 3 libc and many archs, too many ways to resolve .so > > Current code: > -do not parse t