Re: [OpenWrt-Devel] [PATCH 3/3] kernel: rtl8367b: initial support for Realtek switch rtl8367s

2019-08-17 Thread Vincent Wiemann
On 15.08.19 10:28, Serge Vasilugin wrote: > From driver point of view no differance between rtl8367b and rtl8367s > if it connected through EXT2 (rgmii only). > So this trivial patch add some identification and initialization only. > SGMII/HSGMII mode for EXT1 is not implemented for the sake of

Re: [OpenWrt-Devel] [PATCH 2/3] kernel: rtl8367b: add configuration for extended interface 2

2019-08-17 Thread Vincent Wiemann
On 15.08.19 10:28, Serge Vasilugin wrote: > Both rtl8367b and rtl8367s have two extended interface > rtl8367rb: 5 port + 2*RGMII/MII > rtl8367s:  5 port + SGMII/HSGMI + RGMII/MII > (?)rtl8367sb:  5 port + 2*RGMII/MII > These interfaces correpond to EXT1 and EXT2 (ports 6 and 7 respectivly). >

Re: [OpenWrt-Devel] [PATCH 1/3] kernel: rtl8366_smi: explicitly set phy addr for switch

2019-08-17 Thread Vincent Wiemann
Hi Serge, thank you very much for this contribution. I can only give some cosmetic advice. I'm not sure about the functionality. On 15.08.19 10:27, Serge Vasilugin wrote: > By default rtl8366_smi use phy addr 0 at mii-bus to access switch registers. > This patch allow to set it explicitly in

Re: [OpenWrt-Devel] [PATCH 0/3] kernel: add support for realtek rtl8367s

2019-08-17 Thread Chuanhong Guo
Hi! On Thu, Aug 15, 2019 at 4:26 PM Serge Vasilugin wrote: > > Adding support for tplink archer c5 v4 some problems arise: > 1. Device use unsupported rtl8367s switch. > 2. rtl8367s switch have non default 0 phy address at mii-bus (29). > 3. rtl8367s switch is connected through unsupported

Re: [OpenWrt-Devel] [PATCH procd] system: support passing "options" to the "sysupgrade" ubus method

2019-08-17 Thread Jo-Philipp Wich
Hi, > [...] > + > + blobmsg_for_each_attr(option, options, rem) { > + const char *prefix = "UPGRADE_OPT_"; > + char *name = malloc(strlen(prefix) + > strlen(blobmsg_name(option))); > + char value[11]; > + char *c; > + int tmp; > + >