On Tue, 22 Oct 2019 at 12:49, Petr Štetiar wrote:
>
> Petr Štetiar [2019-10-22 06:26:14]:
>
> > Yousong Zhou [2019-10-21 12:59:24]:
> >
> > almost happy:
> >
> > main.c:65:1: warning: Potential leak of memory pointed to by 'args'
> >
> > diff --git a/main.c b/main.c
> > index 12cb4c5c720c..8b11
Petr Štetiar [2019-10-22 06:26:14]:
> Yousong Zhou [2019-10-21 12:59:24]:
>
> almost happy:
>
> main.c:65:1: warning: Potential leak of memory pointed to by 'args'
>
> diff --git a/main.c b/main.c
> index 12cb4c5c720c..8b11418f1c09 100644
> --- a/main.c
> +++ b/main.c
> @@ -62,6 +62,7 @@ exe
Ping.
I still want to fix the existing problems in the qmi protohandler.
Therefore, this feature needs to be integrated into uqmi.
Martin
On 2019-08-29 10:35, Bjørn Mork wrote:
Martin Schiller writes:
On 2019-08-26 21:12, Sami Olmari wrote:
I think the ideology behind proto handler there
Yousong Zhou [2019-10-21 12:59:24]:
almost happy:
main.c:65:1: warning: Potential leak of memory pointed to by 'args'
diff --git a/main.c b/main.c
index 12cb4c5c720c..8b11418f1c09 100644
--- a/main.c
+++ b/main.c
@@ -62,6 +62,7 @@ exec_self(int argc, char **argv)
setenv("RPC_HANGUP",
Signed-off-by: Yousong Zhou
---
package/libs/toolchain/Makefile | 172
toolchain/gcc/final/Makefile| 5 +-
2 files changed, 176 insertions(+), 1 deletion(-)
diff --git a/package/libs/toolchain/Makefile b/package/libs/toolchain/Makefile
index a63746c448..c13
This commit adds support for the ZhuoTK JS76x8 series development boards.
These devices have the following specifications:
- SOC: MT7628AN/NN, MT7688AN, MT7628DAN
- RAM of MT7628AN/NN and MT7688AN: 64/128/256 MB (DDR2)
- RAM of MT7628DAN: 64 MB (DDR2)
- FLASH:8/16/32 MB (SPI NOR)
- Ethernet:3x 10/
Hi Adrian,
I used to use "MediaTek MT7628 EVB" target profile in OpenWRT. This profile
use the default
"wan_mac=$(macaddr_add "$(cat /sys/class/net/eth0/address)" 1)", and the lan
and wan network of my boards work well by use this profile. In
fact, the MAC address at factory partition 0x2e
On 21/10/2019 18:07, Robert Marko wrote:
Merging this today has caused a regression in ipq40xx.
PHY reset patch was is the issue, it now forces devices to have GPIO
for PHY reset which most devices don't have and if it's missing it
will make the driver panic and probing will fail.
So please rever
Hello John,
On 10/21/19 11:44 PM, John Crispin wrote:
> On 21/10/2019 23:41, David Bauer wrote:
>>
>>
>> On 10/21/19 11:40 PM, John Crispin wrote:
>>> On 21/10/2019 23:20, Hauke Mehrtens wrote:
> +define KernelPackage/rtw88
> + $(call KernelPackage/mac80211/Default)
> + TITLE:=Realte
On 21/10/2019 23:41, David Bauer wrote:
On 10/21/19 11:40 PM, John Crispin wrote:
On 21/10/2019 23:20, Hauke Mehrtens wrote:
+define KernelPackage/rtw88
+ $(call KernelPackage/mac80211/Default)
+ TITLE:=Realtek RTL8822BE/RTL8822CE
+ DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPP
On 10/21/19 11:40 PM, John Crispin wrote:
> On 21/10/2019 23:20, Hauke Mehrtens wrote:
>>> +define KernelPackage/rtw88
>>> + $(call KernelPackage/mac80211/Default)
>>> + TITLE:=Realtek RTL8822BE/RTL8822CE
>>> + DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT
>>> +@DRIVER_11W_SUPP
On 21/10/2019 23:20, Hauke Mehrtens wrote:
+define KernelPackage/rtw88
+ $(call KernelPackage/mac80211/Default)
+ TITLE:=Realtek RTL8822BE/RTL8822CE
+ DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT
+@DRIVER_11W_SUPPORT
Please add +@DRIVER_11AC_SUPPORT
V3 here we go
___
On 10/21/19 10:47 PM, David Bauer wrote:
> This commits adds packaging for the new RTW88 driver from Realtek.
> It supports the Realtek 8822BE/8822CE PCIe wireless chips.
>
> For operation, the complementary firmware has to be loaded.
>
> Signed-off-by: David Bauer
> ---
> package/kernel/mac802
eb30a03 libubox, jshn: add option to write output to a file
Signed-off-by: Roman Yeryomin
---
package/libs/libubox/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/libs/libubox/Makefile b/package/libs/libubox/Makefile
index 1c318b3e48..e5f4dcf8fe 100644
Moving a file between tmpfs and other fs is neither
faster nor safer, thus no point in doing it in two steps.
Use new jshn option to write output directly to file.
Originally discussed here:
http://lists.openwrt.org/pipermail/openwrt-devel/2017-December/010127.html
Signed-off-by: Roman Yeryomin
This commits adds packaging for the new RTW88 driver from Realtek.
It supports the Realtek 8822BE/8822CE PCIe wireless chips.
For operation, the complementary firmware has to be loaded.
Signed-off-by: David Bauer
---
package/kernel/mac80211/realtek.mk | 13 -
1 file changed, 12 inse
On 21/10/2019 21:31, David Bauer wrote:
Hello John
On 10/21/19 9:22 PM, John Crispin wrote:
On 21/10/2019 21:13, David Bauer wrote:
+config-$(call config_package,rtw88) += RTW88
+config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
+
why not put it all behind config-$(call config_packa
Hello John
On 10/21/19 9:22 PM, John Crispin wrote:
> On 21/10/2019 21:13, David Bauer wrote:
>> +config-$(call config_package,rtw88) += RTW88
>> +config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
>> +
>
> why not put it all behind config-$(call config_package,rtw88) ? of course
> kbuil
On 21/10/2019 21:13, David Bauer wrote:
+config-$(call config_package,rtw88) += RTW88
+config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
+
why not put it all behind config-$(call config_package,rtw88) ? of
course kbuild will "is not set it" if the prior is not selected but you
could
This commit adds packages for the Realtek RTl8822BE/RTL8822CE firmware
to be used with the rtw88 driver.
Signed-off-by: David Bauer
---
package/firmware/linux-firmware/realtek.mk | 15 +++
1 file changed, 15 insertions(+)
diff --git a/package/firmware/linux-firmware/realtek.mk
b/pa
On 21/10/2019 20:09, Kristian Evensen wrote:
Hi,
On Mon, Oct 21, 2019 at 6:07 PM Robert Marko wrote:
Merging this today has caused a regression in ipq40xx.
PHY reset patch was is the issue, it now forces devices to have GPIO
for PHY reset which most devices don't have and if it's missing it
w
This commits adds packaging for the new RTW88 driver from Realtek.
It supports the Realtek 8822BE/8822CE PCIe wireless chips.
For operation, the complementary firmware has to be loaded.
Signed-off-by: David Bauer
---
package/kernel/mac80211/realtek.mk | 14 +-
1 file changed, 13 ins
Hi,
On Mon, Oct 21, 2019 at 6:07 PM Robert Marko wrote:
>
> Merging this today has caused a regression in ipq40xx.
> PHY reset patch was is the issue, it now forces devices to have GPIO
> for PHY reset which most devices don't have and if it's missing it
> will make the driver panic and probing w
Hi all,
based on Jo Blockers I created a GtiHub-PR [1] which should work as an
comprehensive list for easy review.
Based on a short check of the replies, there are only 3 blockers open. The
RPCd memleak seems to in good progress to get solved.
Thanks to all making this great project
Sven
1 -
Merging this today has caused a regression in ipq40xx.
PHY reset patch was is the issue, it now forces devices to have GPIO
for PHY reset which most devices don't have and if it's missing it
will make the driver panic and probing will fail.
So please revert this until its properly resolved.
__
Device node names were updated, but updating TARGET_DEVICES
was overlooked.
Fixes: 4408723d42e0 ("ramips: remove RAM size from device name
for UniElec devices")
Signed-off-by: Adrian Schmutzler
---
target/linux/ramips/image/mt7621.mk | 4 ++--
target/linux/ramips/image/mt76x8.mk | 2 +-
2 files
On 21.10.19 17:04, Martin Tippmann wrote:
We are using a shell-function to set the prompt based on return code -
it works fine in 17.01 / 18.06 / 19.07, however in current master when
the function is run the terminal/ssh session hangs.
how to reproduce:
<--- hang.sh:
#!/bin/sh
You could a
Hi,
might be related to this:
http://lists.busybox.net/pipermail/busybox/2019-October/087535.html
Regards,
Jo
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
We are using a shell-function to set the prompt based on return code -
it works fine in 17.01 / 18.06 / 19.07, however in current master when
the function is run the terminal/ssh session hangs.
how to reproduce:
<--- hang.sh:
#!/bin/sh
prompt_set() {
face() {
local rc=$?
case "$rc"
Several devices added to LED migration script will just have their
(old) board name converted to tp-link.
By using a variable for this, the amount of code in the migration
script can be reduced and the chance for typos is reduced.
This patch also introduces the marker for beginning of a pattern
"
Several Archer Cxx devices were using board-specific LED names in
ar71xx, which were changed to "tp-link:*" in ath79.
This patch adds migration for them.
Signed-off-by: Adrian Schmutzler
(cherry picked from commit 53e6cc7a81175728f64f978c2363a18c1fa66d64)
---
.../ath79/base-files/etc/uci-defaul
Hi Petr,
I got it from here:
lede/target/linux/ar71xx/files/arch/mips/ath79/nvram.c
Am 21.10.19 um 16:06 schrieb Petr Štetiar:
> André Valentin [2019-10-21 15:13:55]:
>
>> Am 21.10.19 um 15:02 schrieb Petr Štetiar:
>>> André Valentin [2019-10-21 14:32:13]:
>>>
This improves the function
Hi,
Mine were just suggestions; feel free to do it or not! :)
Roger
El 21/10/19 a les 14:53, John Crispin ha escrit:
> On 31/08/2019 23:32, m...@adrianschmutzler.de wrote:
>> "6t@eth0" and "6@eth0" should be the same, so this can be merged with
>> cudy,wr1000.
>
> I meant that part, sorry the ma
The code line patching ath9k MAC address for this device contains
a wrong number of arguments including an unset "$mac", which
looks like a typo or copy/paste mistake.
This has been introduced already in the device support commit
745dee11ac78 ("ath79: add support for WD My Net Wi-Fi Range
Extender
The ar71xx images for the Ubiquiti NanoStation M (XM) devices use
"nanostation-m" as board name, but the ath79 images are only
compatible with the "nano-m" board name, so sysupgrade complains.
By changing this additional supported device, sysupgrade smoothly
upgrades from ar71xx to ath79.
Ref: op
André Valentin [2019-10-21 15:13:55]:
> Am 21.10.19 um 15:02 schrieb Petr Štetiar:
> > André Valentin [2019-10-21 14:32:13]:
> >
> >> This improves the function of_get_mac_address_mtd...
> >
> > but on the other hand its also introducing something which would never be
> > accepted upstream, fo
Based on stock firmware tests, both LAN and WAN ports use the
MAC address from 0x28 on factory partition.
In OpenWrt, this one is already set in DTS. This patch removes the
local bit set in 02_network previously, and adjusts LAN/WAN
addresses as on stock firmware.
Note that in tests we found a MA
Hi,
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of André Valentin
> Sent: Montag, 21. Oktober 2019 14:32
> To: openwrt-devel@lists.openwrt.org
> Cc: avalen...@marcant.net
> Subject: [OpenWrt-Devel] [PATCH 3/5] ath79: add support
Hi Petr,
thanks, I will remove the constant. It is not needed anymore.
Am 21.10.19 um 15:05 schrieb Petr Štetiar:
> André Valentin [2019-10-21 14:32:10]:
>
> Hi,
>
>> #define HEADER_PARTITION_CALC_LENGTH 2048
>> -#define HEADER_PARTITION_LENGTH 0x1
>>
>> struct file_info {
>> cha
Hi Petr!
Am 21.10.19 um 15:02 schrieb Petr Štetiar:
> André Valentin [2019-10-21 14:32:13]:
>
> Hi,
>
>> This improves the function of_get_mac_address_mtd...
>
> but on the other hand its also introducing something which would never be
> accepted upstream, for details see my other comment[1].
André Valentin [2019-10-21 14:32:10]:
Hi,
> #define HEADER_PARTITION_CALC_LENGTH 2048
> -#define HEADER_PARTITION_LENGTH 0x1
>
> struct file_info {
> char *name;/* name of the file */
> @@ -70,6 +69,7 @@ static char *progname;
> static char *board_name = 0;
> static char *vers
André Valentin [2019-10-21 14:32:14]:
> Switch NBG6716 to use the new mtd mac parser for u-boot env.
...
> wifi@0,0 {
> compatible = "qcom,ath10k";
> reg = <0 0 0 0 0>;
...
> + qcom,ath10k-calibration-variant = "ZyXEL-NBG6716";
this doesn't match
André Valentin [2019-10-21 14:32:13]:
Hi,
> This improves the function of_get_mac_address_mtd...
but on the other hand its also introducing something which would never be
accepted upstream, for details see my other comment[1].
> Code has been taken from ar71xx.
It makes me wonder from where e
On Mon, 21 Oct 2019 at 18:44, Petr Štetiar wrote:
>
> Yousong Zhou [2019-10-21 06:10:25]:
>
> Hi,
>
> > Yousong Zhou (6):
>
> seems like two patches didn't made it to the mailing list and/or patchwork.
>
> -- ynezz
Oops.. Resent the two patches as reply to this cover letter.
Regards,
Signed-off-by: Yousong Zhou
---
main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/main.c b/main.c
index 1db3241..12cb4c5 100644
--- a/main.c
+++ b/main.c
@@ -47,12 +47,16 @@ static void
exec_self(int argc, char **argv)
{
int i;
- const char *cmd
Signed-off-by: Yousong Zhou
---
file.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/file.c b/file.c
index b1adcb7..47fcd9a 100644
--- a/file.c
+++ b/file.c
@@ -823,13 +823,15 @@ rpc_file_exec_run(const char *cmd, const struct blob_attr
*sid,
if
On 21/10/2019 14:30, Adrian Schmutzler wrote:
Hi John,
-Original Message-
From: John Crispin [mailto:j...@phrozen.org]
Sent: Montag, 21. Oktober 2019 14:19
To: Adrian Schmutzler ;
openwrt-devel@lists.openwrt.org
Subject: Re: [OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices
On 31/08/2019 23:32, m...@adrianschmutzler.de wrote:
"6t@eth0" and "6@eth0" should be the same, so this can be merged with
cudy,wr1000.
I meant that part, sorry the mail was sitting in my draft folder
John
___
openwrt-devel mailing list
open
Dear maintainers,
Do you request me to make all of the changes proposed by Roger
(including adding u-boot data? But the env partition is marked
read-only and most other targets do not do that)? Or the merging
proposed by Adrian?
Please clarify!
--
Be free, use free (http://www.gnu.org/philosoph
Attention: Kernel partition size has been enlarged to 4MB.
To switch, you must update to latest ar71xx-nand snapshort and flash the
image:
mtd -r write openwrt-ath79-nand-zyxel_nbg6716-squashfs-sysupgrade-4M-Kernel.bin
firmware
You will end up with a fresh config if you do not inject config into t
This improves the function of_get_mac_address_mtd the be able to handle
u-boot environement. It is now possible to read a MAC address from the env
and set this in the dt.
Code has been taken from ar71xx.
Signed-off-by: André Valentin
---
...ET-add-of_get_mac_address_mtd_search.patch | 96 +++
-Fix the kernel image generation (more robust)
-Add a firmware partition table allowing easy upgrade to ath79
Signed-off-by: André Valentin
---
target/linux/ar71xx/image/legacy.mk | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/linux/ar71xx/image/legacy.mk
b/tar
Switch NBG6716 to use the new mtd mac parser for u-boot env.
Signed-off-by: André Valentin
---
.../linux/ath79/dts/qca9558_zyxel_nbg6716.dts | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/target/linux/ath79/dts/qca9558_zyxel_nbg6716.dts
b/target/linux/a
This patchset does the following:
-Fix image generation for old ar71xx images
-Add a firmware partition the the old ar71xx images (allowing migration)
-Add ath79 support for NBG6716
-Add a MAC parser for DTS allowing u-boot-env as MAC source
André Valentin (5):
tools/mkrasimage: Add support for
128k header size support is needed for ZyXEL NBG6716.
Signed-off-by: André Valentin
---
tools/firmware-utils/src/mkrasimage.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/firmware-utils/src/mkrasimage.c
b/tools/firmware-utils/src/mkrasimage.c
index 8eee
Hi John,
> -Original Message-
> From: John Crispin [mailto:j...@phrozen.org]
> Sent: Montag, 21. Oktober 2019 14:19
> To: Adrian Schmutzler ;
> openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices to
> interrupt-driven gpio-keys
>
On 23/08/2019 15:57, Denis Kalashnikov wrote:
It is needed to reuse qmi code, e.g. in a modem manager util
which is useful on routers with several cell modems.
Signed-off-by: Denis Kalashnikov
Hi,
patch looks looks but
+Index: uqmi-2019-06-27-1965c713/dev.c
+==
On 20/09/2019 14:03, Adrian Schmutzler wrote:
This converts all remaining devices to use interrupt-driven
gpio-keys compatible instead of gpio-keys-polled.
The poll-interval is removed.
While at it, add/remove newlines in keys and leds node where
necessary.
Signed-off-by: Adrian Schmutzler
H
This is based on the EX6150v2, which should be identical to
the EX6100v2:
The device bears two MAC addresses ("MAC 1" and "MAC 2") that
correspond to phy0 and phy1.
The ethernet MAC address (gmac0) is the same as phy0.
As this one is accessible via local-mac-address in gmac0, the
latter is used f
If flash size is used as part of a device's title, it should be
specified as DEVICE_VARIANT like for the other devices so far.
Signed-off-by: Adrian Schmutzler
---
target/linux/ipq40xx/image/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/linux/ipq40xx/image
On 20/10/2019 08:01, Gerard Ryan wrote:
This is primarily to satiate the usage by docker/libnetwork.
Behaviour mirrors /tools/modprobe.c from https://git.kernel.org
Hi,
you should describe here what the -a flag actually does.
I have manually fixed it for 1/2 but please rework 2/2 and send that o
Yousong Zhou [2019-10-21 06:10:25]:
Hi,
> Yousong Zhou (6):
seems like two patches didn't made it to the mailing list and/or patchwork.
-- ynezz
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinf
For improved reusability, testing etc.
Signed-off-by: Petr Štetiar
---
Makefile | 57 ---
src/attr.c => attr.c | 0
src/cache.c => cache.c| 0
src/cache_mngt.c => cache_mngt.c |
Uses currently proof-of-concept openwrt-ci[1] in order to:
* improve the quality of the codebase in various areas
* decrease code review time and help merging contributions faster
* get automagic feedback loop on various platforms and tools
- out of tree build with OpenWrt SDK on following t
Let's enforce additional automatic checks enforced by the compiler in
order to catch possible errors during compilation.
Signed-off-by: Petr Štetiar
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4924586e893c..e7d7f861
gcc 9.1 on x86/64 has reported following:
attr.c:403:19: error: comparison of integer expressions of different
signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
genl.c:154:24: error: comparison of integer expressions of different
signedness: ‘int’ and ‘unsigned int’ [-Werror=sig
Aligning it with other C based projects.
Signed-off-by: Petr Štetiar
---
CMakeLists.txt | 38 ++
Makefile | 17 -
libnl-tiny.pc| 10 --
libnl-tiny.pc.in | 10 ++
4 files changed, 48 insertions(+), 27 deletions(-)
67 matches
Mail list logo
