On 30/11/2019 22:44, Tom Psyborg wrote:
> On 26/11/2019, Stijn Tintel wrote:
>> On 26/11/2019 00:34, Hauke Mehrtens wrote:
>>> It looks like there is a throughput problem with ath10k-ct on QCA9984,
>>> https://bugs.openwrt.org/index.php?do=details&task_id=2593
>>> there are multiple reports in the
Found with clang's -Wextra-semi-stmt
Fixes:
error: empty expression statement has no effect; remove unnecessary ';' to
silence this warning [-Werror,-Wextra-semi-stmt]
UCI_TRAP_SAVE(ctx, error);
^
error: empty expression statement has no ef
A const char * variable is being passed as a format string. Unfortunately,
this is not correct.
A constant expression needs to be passed so that GCC can determine the
types of the format properly.
Also fixed a different warning that needs a printf attribute.
Fixes:
error: format not a string li
On Sat, Nov 30, 2019 at 7:41 AM Petr Štetiar wrote:
>
> Petr Štetiar [2019-11-30 15:04:40]:
>
> > Wouldn't it make sense to enable following hardening flags (maybe consider
> > others as well?):
> >
> > -Werror=format-security
> > -Werror=format-nonliteral
>
> FYI, following uci patch:
>
> d
On 26/11/2019, Stijn Tintel wrote:
> On 26/11/2019 00:34, Hauke Mehrtens wrote:
>> It looks like there is a throughput problem with ath10k-ct on QCA9984,
>> https://bugs.openwrt.org/index.php?do=details&task_id=2593
>> there are multiple reports in the Forum.
>>
>> For me QCA9880 on a BTHH5A with
>
>
>> Wouldn't it make sense to enable following hardening flags (maybe consider
>> others as well?):
>>
>> -Werror=format-security
>> -Werror=format-nonliteral
Actually the flag I used was -Werror=format=2. It includes all of them.
The nonliteral warning is not applicable everywhere. In so
Petr Štetiar [2019-11-30 15:04:40]:
> Wouldn't it make sense to enable following hardening flags (maybe consider
> others as well?):
>
> -Werror=format-security
> -Werror=format-nonliteral
FYI, following uci patch:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 92adf4a47121..56a14e2
Rosen Penev [2019-11-29 13:07:29]:
Hi,
> A constant expression needs to be passed so that GCC can determine the
> types of the format properly.
indeed, good catch!
> -Werror=format-nonliteral
Wouldn't it make sense to enable following hardening flags (maybe consider
others as well?):
-Werr
