[OpenWrt-Devel] [PATCH] samba36: log error if getting device info failed

2019-12-29 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- package/network/services/samba36/Makefile| 2 +- package/network/services/samba36/files/samba.hotplug | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/package/network/services/samba36/Makefile

[OpenWrt-Devel] [PATCH] iptables: update to 1.8.4

2019-12-29 Thread DENG Qingfang
Update iptables to 1.8.4 ChangeLog: https://netfilter.org/projects/iptables/files/changes-iptables-1.8.4.txt Signed-off-by: DENG Qingfang --- package/network/utils/iptables/Makefile | 6 +++--- .../utils/iptables/patches/600-shared-libext.patch | 12 ++--

[OpenWrt-Devel] [PATCHv2 1/4] scripts/gen_image_generic.sh: Replace -o with ||

2019-12-29 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2d2fb120ce..1e35b1b349 100755 ---

[OpenWrt-Devel] [PATCHv2 3/4] scripts/gen_image_generic.sh: Replace deprecated `` with $()

2019-12-29 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 9f3e4d024c..0832bf91de 100755 --- a/scripts/gen_image_generic.sh +++

[OpenWrt-Devel] [PATCHv2 4/4] scripts/gen_image_generic.sh: use /bin/sh

2019-12-29 Thread Rosen Penev
This has nothing bash specific. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 0832bf91de..6a8065e15a 100755 --- a/scripts/gen_image_generic.sh +++

[OpenWrt-Devel] [PATCHv2 2/4] scripts/gen_image_generic.sh: Remove $ in arithmetic

2019-12-29 Thread Rosen Penev
Fixes shellcheck warning: SC2004: $/${} is unnecessary on arithmetic variables. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index

Re: [OpenWrt-Devel] [PATCH 4/4] scripts/gen_image_generic.sh: use /bin/sh

2019-12-29 Thread Rosen Penev
On Sun, Dec 29, 2019 at 8:19 PM Stefan Lippers-Hollmann wrote: > > Hi > > On 2019-12-29, Rosen Penev wrote: > > This has nothing bash specific. > [...] > > +++ b/scripts/gen_image_generic.sh > > @@ -1,4 +1,4 @@ > > -#!/usr/bin/env bash > > +#!/bin/bash > > I assume this was supposed to become

Re: [OpenWrt-Devel] [PATCH 4/4] scripts/gen_image_generic.sh: use /bin/sh

2019-12-29 Thread Stefan Lippers-Hollmann
Hi On 2019-12-29, Rosen Penev wrote: > This has nothing bash specific. [...] > +++ b/scripts/gen_image_generic.sh > @@ -1,4 +1,4 @@ > -#!/usr/bin/env bash > +#!/bin/bash I assume this was supposed to become #!/bin/sh instead? Regards Stefan Lippers-Hollmann -- Thanks for looking into

Re: [OpenWrt-Devel] [PATCH 4/4] scripts/gen_image_generic.sh: use /bin/sh

2019-12-29 Thread Lars Kruse
Hello Rosen, Am Sun, 29 Dec 2019 19:42:51 -0800 schrieb Rosen Penev : > This has nothing bash specific. > [..] > -#!/usr/bin/env bash > +#!/bin/bash I think, the commit message indicates that you switched from bash to sh. Or did I misread it somehow? Cheers, Lars

[OpenWrt-Devel] [PATCH 1/4] scripts/clean-package.sh: exit in case cd fails

2019-12-29 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/clean-package.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 6dd9bf7306..987e6685a8 100755 --- a/scripts/clean-package.sh +++

[OpenWrt-Devel] [PATCH 2/4] scripts/clean-package.sh: Use read -r

2019-12-29 Thread Rosen Penev
read will mangle backslashes. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/clean-package.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 987e6685a8..e849c41afa 100755 ---

[OpenWrt-Devel] [PATCH 3/4] scripts/clean-package.sh: Remove useless cat

2019-12-29 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/clean-package.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index e849c41afa..b64d7ad21a 100755 --- a/scripts/clean-package.sh +++

[OpenWrt-Devel] [PATCH 4/4] scripts/clean-package.sh: Switch from -a in if to &

2019-12-29 Thread Rosen Penev
-a is not well defined. Signed-off-by: Rosen Penev --- scripts/clean-package.sh | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index b64d7ad21a..2c9d4169ba 100755 --- a/scripts/clean-package.sh +++

[OpenWrt-Devel] [PATCH 1/4] scripts/gen_image_generic.sh: Replace -o with ||

2019-12-29 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2d2fb120ce..1e35b1b349 100755 ---

[OpenWrt-Devel] [PATCH 4/4] scripts/gen_image_generic.sh: use /bin/sh

2019-12-29 Thread Rosen Penev
This has nothing bash specific. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 0832bf91de..6a8065e15a 100755 --- a/scripts/gen_image_generic.sh +++

[OpenWrt-Devel] [PATCH 3/4] scripts/gen_image_generic.sh: Replace deprecated `` with $()

2019-12-29 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 9f3e4d024c..0832bf91de 100755 --- a/scripts/gen_image_generic.sh +++

[OpenWrt-Devel] [PATCH 2/4] scripts/gen_image_generic.sh: Remove $ in arithmetic

2019-12-29 Thread Rosen Penev
Fixes shellcheck warning: SC2004: $/${} is unnecessary on arithmetic variables. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index

[OpenWrt-Devel] [PATCH 1/3] toolchain/wrapper: Replace legacy `` with $()

2019-12-29 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- target/toolchain/files/wrapper.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/toolchain/files/wrapper.sh b/target/toolchain/files/wrapper.sh index 4452128382..bd4996cac2 100755 ---

[OpenWrt-Devel] [PATCH 2/3] toolchain/wrapper.sh: Replace read with read -r

2019-12-29 Thread Rosen Penev
Without -r, backslashes would get mangled. Found with shellcheck. Signed-off-by: Rosen Penev --- target/toolchain/files/wrapper.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/toolchain/files/wrapper.sh b/target/toolchain/files/wrapper.sh index

[OpenWrt-Devel] [PATCH 3/3] toolchain/wrapper.sh: Use /bin/sh instead of bash

2019-12-29 Thread Rosen Penev
No bash features are actually used here. Signed-off-by: Rosen Penev --- target/toolchain/files/wrapper.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/toolchain/files/wrapper.sh b/target/toolchain/files/wrapper.sh index ba2b34778f..d42c6a14d5 100755 ---

[OpenWrt-Devel] [PATCH] rt2x00: add throughput LED trigger

2019-12-29 Thread David Bauer
This adds a (currently missing) throughput LED trigger for the rt2x00 driver. Previously, LED triggers had to be assigned to the netdev, which was limited to a single VAP. Signed-off-by: David Bauer Tested-by: Christoph Krapp --- .../612-rt2x00-led-tpt-trigger-support.patch | 44

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Štetiar
Petr Novák via openwrt-devel [2019-12-29 11:49:36]: Hi, thanks for reporting it and sorry for the breakage. > Reading partition table from bootdisk... > Reading partition table from image... > Saving config files... > Commencing upgrade. Closing all shell sessions. > { > "error": { >

[OpenWrt-Devel] [sdwalker/sdwalker.github.io] b52356: This week's update

2019-12-29 Thread Stephen Walker
Branch: refs/heads/master Home: https://github.com/sdwalker/sdwalker.github.io Commit: b52356ed22538d192add9776624c48933490155f https://github.com/sdwalker/sdwalker.github.io/commit/b52356ed22538d192add9776624c48933490155f Author: Stephen Walker Date: 2019-12-29 (Sun, 29 Dec

Re: [OpenWrt-Devel] Problem with blockd starting after partitions mounting

2019-12-29 Thread Alberto Bursi
On 29/12/19 15:35, Rafał Miłecki wrote: A year ago I introduced hotplug.d script meant to manage Samba shares in a clever way by: 1) Using "mount" hotplug.d event 2) Getting mount info from blockd Relevant commit ef1efa756e0d ("samba36: add package with hotplug.d script for auto sharing"):

[OpenWrt-Devel] Problem with blockd starting after partitions mounting

2019-12-29 Thread Rafał Miłecki
A year ago I introduced hotplug.d script meant to manage Samba shares in a clever way by: 1) Using "mount" hotplug.d event 2) Getting mount info from blockd Relevant commit ef1efa756e0d ("samba36: add package with hotplug.d script for auto sharing"):

Re: [OpenWrt-Devel] [PATCH fstools] Revert "block: mount_action: handle mount/umount deps"

2019-12-29 Thread Yousong Zhou
On Sat, 28 Dec 2019 at 18:27, Rafał Miłecki wrote: > > On 27.12.2019 13:25, Yousong Zhou wrote: > > On Fri, 27 Dec 2019 at 16:53, Rafał Miłecki wrote: > >> > >> From: Rafał Miłecki > >> > >> This reverts commit 32c3126b2f0464106d74317336b6aef1d7d5f82f. > >> > >> Internal list of devices

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Novák via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hannu was correct - the root

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Novák via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- So rolling back ubus to the

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Novák via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- > On 29 Dec 2019, at 13:13,

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Hannu Nyman
Petr Novák kirjoitti 29.12.2019 klo 13.49: I am normally building my own images, but to make sure this is easy to reproduce, I have recreated the problem with the most recent snapshot builds as well. Can you be explicit with "most recent"? You mean r11829-e3e939d8e6 images that contain the

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Novák via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- I was also suffering from this

Re: [OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Hannu Nyman
> The problem does not seem to be with the image - older builds upgrade to the same image just fine, but the recent ones seem to fail. > > Example: taking the most recent rpi-4-squashfs-factory.img.gz from 2019-12-28 and trying to upgrade to rpi-4-squashfs-sysupgrade.img.gz from the same date

[OpenWrt-Devel] Sysupgrade possibly broken in recent development snapshots: "message": "Firmware image couldn't be validated"

2019-12-29 Thread Petr Novák via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- I seem to be experiencing a