Missing local variables and quoting fixes.
Signed-off-by: Rosen Penev
---
package/network/utils/wireguard-tools/Makefile | 2 +-
.../network/utils/wireguard-tools/files/wireguard.sh | 10 +++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/package/network/utils/w
Speeds up config generation.
Signed-off-by: Rosen Penev
---
v3: Fix title
v2: Added PKG_RELEASE bump.
.../utils/wireguard-tools/files/wireguard.sh | 64 +--
1 file changed, 30 insertions(+), 34 deletions(-)
diff --git a/package/network/utils/wireguard-tools/files/wireguard.sh
read mangles backslashes.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/env b/scripts/env
index 848850a778..c81fbf8ddc 100755
--- a/scripts/env
+++ b/scripts/env
@@ -42,7 +42,7 @@ ask_bool() {
Simpler and built in to the shell.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/env b/scripts/env
index 7bfca58c5d..563f39c1cf 100755
--- a/scripts/env
+++ b/scripts/env
@@ -57,7 +57,7 @@ env_init()
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/env b/scripts/env
index 19cfa13841..848850a778 100755
--- a/scripts/env
+++ b/scripts/env
@@ -147,7 +147,7 @@ env_clear() {
else
r
The latter is more standard. The former throws an error under
shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/env b/scripts/env
index 563f39c1cf..19cfa13841 100755
--- a/scripts/env
+++ b/scripts/env
@@ -73,7
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index def3d3c7c2..53b9ec5f20 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -55,7 +55,7 @@ if [ -z "${ARCH}"
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 53b9ec5f20..c09e537dbd 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -43,7 +43,7 @@ do
k
This no longer needs bash.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index c09e537dbd..62cfc21c6b 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bas
echo flags are not POSIX. printf does the same with added \n.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 32a978e18d..def3d3c7c2 100755
--- a/scripts/mkits
These are in if statements (where they should be), and echo output that is
not piped to anything. These should be safe.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/flashing/flash.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/flashing
The script no longer uses any features that necessitate bash.
Also removed trailing whitespace.
Signed-off-by: Rosen Penev
---
scripts/flashing/flash.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh
index aea
echo flags are an extension and not available with sh. printf does the
same as -en.
Signed-off-by: Rosen Penev
---
scripts/flashing/flash.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh
index 7f2cdf5db9..aea1bf1
This has nothing bash specific.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 527ca5bacc..5162be11dd 100755
--- a/scripts/gen_image_generic.sh
+++ b
-o is not well defined.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 2c57d56f07..527ca5bacc 100755
--- a/scripts/gen_im
Hi Enrico,
> -Original Message-
> From: Enrico Mioso [mailto:mrkiko...@gmail.com]
> Sent: Dienstag, 17. September 2019 19:59
> To: m...@adrianschmutzler.de
> Cc: Filip Moc ; openwrt-devel@lists.openwrt.org
> Subject: RE: [OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-
> MR6400
>
Without this commit, ft_psk_generate_local is enabled for non-PSK
networks by default. This breaks 802.11r for EAP networks.
Disable ft_psk_generate_local by default for non-PSK networks resolves
this misbehavior.
Reported-by: Martin Weinelt
Signed-off-by: David Bauer
Tested-by: Martin Weinelt
Branch: refs/heads/master
Home: https://github.com/sdwalker/sdwalker.github.io
Commit: 9a4ea277be13410f72ab6a36931401cbb886960f
https://github.com/sdwalker/sdwalker.github.io/commit/9a4ea277be13410f72ab6a36931401cbb886960f
Author: Stephen Walker
Date: 2020-01-05 (Sun, 05 Jan 2
Hi there,
I wish you all the best for 2020!
We're planning to apply for Google Summer of Code (GSoC) again. GSoC is
a program by Google to bring student developers into Open Source projects.
tl;dr: Google pays students for 3 months in summer developing software
for an open source project. Therefo
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Adrian Schmutzler
> Sent: Sonntag, 5. Januar 2020 17:38
> To: openwrt-devel@lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH 0/5] Remove kernel 4.9 targets and kernel
> 4.9 support
Hi,
> When I use sysupgrade in 18.06 it executes the platform_check_image()
> functions which calls nand_do_platform_check("mir3g",
> "/tmp/openwrt-19.07-ramips-mt7621-xiaomi_mir3g-squashfs-sysupgrade.bin")
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ramips/base-files
On 1/5/20 5:37 PM, m...@adrianschmutzler.de wrote:
> Hi Hauke,
>
>> -Original Message-
>> From: Hauke Mehrtens [mailto:ha...@hauke-m.de]
>> Sent: Sonntag, 5. Januar 2020 15:18
>> To: openwrt-devel@lists.openwrt.org
>> Cc: m...@adrianschmutzler.de; d...@kresin.me; Hauke Mehrtens
>>
>> Subj
After kernel 4.9 has been removed, this removes all (now obsolete)
kernel version switches that deal with versions before 4.14.
Package kmod-crypto-iv is empty now and thus removed entirely.
Signed-off-by: Adrian Schmutzler
---
include/netfilter.mk | 26 +++
This removes support for the remaining three kernel 4.9 targets, and
after that for the now "unused" kernel 4.9 support.
The targets seem to be not maintained anymore, for two of them there
were even patches available to bump them to 4.14, but nobody even
attempted to test them.
Support will stay
This target is still on kernel 4.9, and it looks like there is no
active maintainer for this target anymore.
Remove the code and all the packages which are only used by this target.
To add this target to OpenWrt again port it to a recent and supported
kernel version.
Signed-off-by: Adrian Schmutz
Hi Hauke,
> -Original Message-
> From: Hauke Mehrtens [mailto:ha...@hauke-m.de]
> Sent: Sonntag, 5. Januar 2020 15:18
> To: openwrt-devel@lists.openwrt.org
> Cc: m...@adrianschmutzler.de; d...@kresin.me; Hauke Mehrtens
>
> Subject: [PATCH] ramips: Fix sysupgrade for Xiaomi mir3g
>
> With
Hi Adrian, Tom,
On 05.01.2020 16:57, m...@adrianschmutzler.de wrote:
-Original Message-
From: Tom Psyborg [mailto:pozega.tomis...@gmail.com]
Sent: Sonntag, 5. Januar 2020 16:33
To: m...@adrianschmutzler.de
Cc: Hauke Mehrtens ; OpenWrt Development List
; Koen Vandeputte
Subject: Re: [Ope
> -Original Message-
> From: Tom Psyborg [mailto:pozega.tomis...@gmail.com]
> Sent: Sonntag, 5. Januar 2020 16:33
> To: m...@adrianschmutzler.de
> Cc: Hauke Mehrtens ; OpenWrt Development List
> ; Koen Vandeputte
>
> Subject: Re: [OpenWrt-Devel] Kernel version for OpenWrt 20.X
>
> On 05/0
On 05/01/2020, m...@adrianschmutzler.de wrote:
> Hi,
>
>> -Original Message-
>> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
>> On Behalf Of Hauke Mehrtens
>> Sent: Samstag, 4. Januar 2020 18:26
>> To: m...@adrianschmutzler.de; 'OpenWrt Development List' > de...@lis
On 1/5/20 3:17 PM, Hauke Mehrtens wrote:
> Without this change sysupgrade from 18.06 to 19.07 is only possible with
> the -F option.
> In OpenWrt 18.06 the nand_do_platform_check() function is called with
> the board name mir3g only, if the tar does not use mir3g it will fail.
> OpenWrt 19.07 and l
Without this change sysupgrade from 18.06 to 19.07 is only possible with
the -F option.
In OpenWrt 18.06 the nand_do_platform_check() function is called with
the board name mir3g only, if the tar does not use mir3g it will fail.
OpenWrt 19.07 and later support the metadata with the supported_device
On 1/5/20 2:43 PM, m...@adrianschmutzler.de wrote:
> On 11/28/19 7:11 PM, Adrian Schmutzler wrote:
>> Hi Hauke,
>>
>>> The following are still on kernel 4.9:
>>> * ar7
>>> * ixp4xx
>>> * orion
>>
>> There are patches (actually from you, May 2019) on the list w
> > >> On 11/28/19 7:11 PM, Adrian Schmutzler wrote:
> > >>> Hi Hauke,
> > >>>
> > The following are still on kernel 4.9:
> > * ar7
> > * ixp4xx
> > * orion
> > >>>
> > >>> There are patches (actually from you, May 2019) on the list which
> > >>> claim to bump ar7 and orion t
Hi,
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Hauke Mehrtens
> Sent: Samstag, 4. Januar 2020 18:26
> To: m...@adrianschmutzler.de; 'OpenWrt Development List' de...@lists.openwrt.org>
> Cc: 'Koen Vandeputte'
> Subject: Re: [
Hauke Mehrtens [2020-01-04 20:41:44]:
> > + vjson_error(err, "unhandled error");
>
> In which case is this returned, aren't there specific error handlers in
> call cases now and vjson_parse() would overwrite it again?
It should be returned in unhandled cases, in case I've missed to handle
some
On 1/5/20 11:40 AM, Petr Štetiar wrote:
> Hauke Mehrtens [2020-01-04 20:41:44]:
>
> Hi,
>
> thanks for the review!
>
>> Please annotate the function with:
>> __attribute__ ((format (printf, 2, 3)));
>
> Done.
>
>>> + va_start(va, fmt);
>>> + r = vsnprintf(buf+r, sizeof(buf)-r, fmt, va);
>
Hauke Mehrtens [2020-01-04 20:41:44]:
Hi,
thanks for the review!
> Please annotate the function with:
> __attribute__ ((format (printf, 2, 3)));
Done.
> > + va_start(va, fmt);
> > + r = vsnprintf(buf+r, sizeof(buf)-r, fmt, va);
>
> Please check here for truncation:
>
> rv = vsnprintf(buf+
Currently the patch only changes break to use goto statement instead.
But not necessary acutually since the ret value checked after the for loop.
So it is okay for the break case before changed by the patch also.
This patch only reverts the following commit partially.
https://github.com/openwrt/
The following commit changes are mainly applied into the linux kernel upstream.
https://github.com/openwrt/openwrt/commit/ddc11c3932c7b7b7df7d5fbd48f207e77619eaa7
So it is not necessary to remain current patches and remove them.
Tokunori Ikegami (2):
ar71xx: Remove mtd cfi_cmdset_0002 status
Currently the patch only changes break to use goto statement instead.
But not necessary acutually since the ret value checked after the for loop.
So it is okay for the break case before changed by the patch also.
This patch only reverts the following commit partially.
https://github.com/openwrt
40 matches
Mail list logo
