Not needed.
https://github.com/koalaman/shellcheck/wiki/Sc2004
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions/system.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/base-files/files/lib/functions/system.sh
b/package/base-files/files/lib/fun
It's cleaner and faster as it does not need to do extra work.
Also removed $() to avoid executing the output. The shell can handle it.
https://github.com/koalaman/shellcheck/wiki/SC2143
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 8
1 file changed, 4 ins
It does word splitting and glob expansion, which is undesirable.
https://github.com/koalaman/shellcheck/wiki/SC2045
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/base-files/files/lib/functio
The cut command can take a file as an input.
https://github.com/koalaman/shellcheck/wiki/SC2002
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/base-files/files/lib/functions.sh
b/package/b
$(which) must be executed. command -v is a shell builtin.
https://github.com/koalaman/shellcheck/wiki/SC2230
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/base-files/files/lib/functions.sh
-a is not well defined.
https://github.com/koalaman/shellcheck/wiki/SC2166
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/base-files/files/lib/functions.sh
b/package/base-files/files/lib/f
It's not needed. It can also lead to subtle bugs.
https://github.com/koalaman/shellcheck/wiki/Sc2004
Signed-off-by: Rosen Penev
---
package/base-files/files/lib/functions.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/base-files/files/lib/functions.sh
b/pa
From: Pavel Balan
This patch adds support for the COMFAST CF-E130N v2, an outdoor wireless
CPE with a single Ethernet port and a 802.11bgn radio.
Specifications:
- QCA9531 SoC
- 1x 10/100 Mbps Ethernet with PoE-in support
- 64 MB of RAM (DDR2)
- 16 MB of FLASH
- 5 dBi built-in antenna
- P
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Hi,
> Would you provide a proper
The flowtable detection fails if the respective target module is built-in,
since it's looking for the module itself. Create a generic helper and
instead check for existence of the FLOWTABLE target in
/proc/net/ip_tables_targets.
Signed-off-by: Rui Salvaterra
---
defaults.c | 24 ++---
On Thu, Jan 16, 2020 at 12:42 PM Hans Dedecker wrote:
> On Thu, Jan 16, 2020 at 4:36 PM DENG Qingfang
> wrote:
> >
> > Update ccache to 3.7.7
> >
> > Release notes:
> > https://ccache.dev/releasenotes.html#_ccache_3_7_7
> >
> > Signed-off-by: DENG Qingfang
> Patch applied, thx
>
> Hans
> > ---
Hi!
Speaking as a small part-time contributor of some Netgear WN(D)R routers
code, please reconsider if jumping over 4.19 straight to 5.4 is not a
too big leap. I'm sure kernel devs here knows better than me how many
OpenWrt drivers, quirks and enhancements can be ported without too much
effort fr
On Thu, Jan 16, 2020 at 4:36 PM DENG Qingfang wrote:
>
> Update ccache to 3.7.7
>
> Release notes:
> https://ccache.dev/releasenotes.html#_ccache_3_7_7
>
> Signed-off-by: DENG Qingfang
Patch applied, thx
Hans
> ---
> tools/ccache/Makefile | 4 ++--
> tools/ccache/patches/1
Thanks for feedback
I think this behavior is not really acceptable. Programs, init scripts,
hotplug events etc. should not automatically modify (and commit) uci
configurations, especially not such vital ones like the network config.
The new wireguard init script is only executed if the network
Update ccache to 3.7.7
Release notes:
https://ccache.dev/releasenotes.html#_ccache_3_7_7
Signed-off-by: DENG Qingfang
---
tools/ccache/Makefile | 4 ++--
tools/ccache/patches/100-honour-copts.patch | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tool
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of Adrian Schmutzler
> Sent: Donnerstag, 16. Januar 2020 12:51
> To: openwrt-devel@lists.openwrt.org
> Cc: Robert Marko
> Subject: [OpenWrt-Devel] [PATCH v2 4/5] base-files: wifi: add 80
Hi,
> + case "$wpa_cipher" in
> + GCMP)
> + append network_data "pairwise=GCMP" "$N$T"
> + append network_data "group=GCMP" "$N$T"
> + ;;
> + esac
> +
how is this supposed to work and look like in uci? I couldn't find any
oth
Hi,
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of Daniel Golle
> Sent: Donnerstag, 16. Januar 2020 10:04
> To: Nick
> Cc: openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH 0/5] Add 802.11ad support
>
> Hi Ni
From: Robert Marko
This patch adds wil6210 driver for Wilocity/QCA based 802.11ad
PCI cards.
Driver uses cfg80211 and nl80211 but not mac80211.
Integration for UCI and LuCI will come in other patches.
Signed-off-by: Robert Marko
---
package/kernel/mac80211/ath.mk | 18 +++---
1 fi
From: Robert Marko
This patch adds wil6210 firmware and board files.
Firmware version is not up to date but is only freely
redistributable one I found.
Board file is a generic one so most devices and especially those
for long distance PtP links will require so in a ipq-wifi like way.
Signed-off-
From: Robert Marko
This patch adds support for 802.11ad to mac80211.sh script.
It checks whether device supports 802.11ad Channel 1 and if so
configures it to channel 1 and ad hwmode.
htmode is not needed for 802.11ad.
Signed-off-by: Robert Marko
[rewrite if/else logic in mac80211.sh]
Signed-of
From: Robert Marko
This patch enables hostapd.sh to properly configure wpa_supplicant
for when GCMP is used as cipher in station mode.
Without this wpa_supplicant will be unable to connect to AP.
This is needed for wil6210 as it does not support CCMP.
Signed-off-by: Robert Marko
[remove empty d
From: Robert Marko
This patch adds 802.11ad support by adding 11ad hwmode identifier.
This way hostapd.sh requires no modifications as for 802.11ad only
hwmode and channel are needed as channel width is fixed to 2160MHz
and there are no HT modes.
Signed-off-by: Robert Marko
---
package/base-fi
Peter Geis [2020-01-15 21:15:41]:
Hi,
tl;dr I'm going to vote in favor of skipping release with 4.19 and focus on
5.4 kernel.
The 19.07 release was delayed by a few months, so this has affected the
subsequent release as well. The plan is to have stable release every 6 months
as it is easier to
And does the device have a MAC address printed on it? I would assume the one
from WiFi?
> -Original Message-
> From: Filip Moc [mailto:l...@moc6.cz]
> Sent: Donnerstag, 16. Januar 2020 09:31
> To: m...@adrianschmutzler.de
> Cc: 'Enrico Mioso' ; openwrt-devel@lists.openwrt.org
> Subject: R
Hi,
thanks for your feedback.
I currently consider merging this (considering your reply on my questions
below) and would include the few minor remaining issues as "Known issues" in
the commit message.
Would you provide a proper Tested-by?
> -Original Message-
> From: Filip Moc [mailto
Hi,
> Does anyone else see any other topic which should be included in this combined
> vote? If so, let us know ASAP and ideally prepare the text/voting options as
> well.
while I wouldn't add the whole auto-deletion topic to the discussion yet, I'd
be happy to ask for permission to delete/auto-
Hauke Mehrtens [2020-01-16 00:00:33]:
Hi,
> My preferred timeline would the the following:
> * Beginning of February: freeze master for big changes (adding new
> boards is no problem)
> * Beginning of March: branch off 20.3 release branch
> * 1 week after the branch was created: tag and build 20
Hi (again),
So that's what happends when you use git format-patch without thought.
This message came from me, just had Petr's From: because the original
patch I picked into my git tree came from him.
Sorry for that...
Cheers
Daniel
On Thu, Jan 16, 2020 at 11:13:22AM +0200, Petr Štetiar wrote:
>
Hi Petr,
Hi Felix,
seems like more things were wrong with instance_config_move(), some
of the jail attributes were missing as well...
---
Commit a5af33ce9a16 ("instance: strdup string attributes") has
introduced duplication of various string attributes in order to fix
use-after-free, but missed h
Hi Nick,
On Thu, Jan 16, 2020 at 09:08:01AM +0100, Nick wrote:
> Why are this patches not merged upstream?
Probably because nobody suitable hardware at hand could review and test
the patches. Probably it'd be better to first add the basic device
bring-up and then add 11ad support.
> You always h
Hi,
> + if [ -z "$public_key" ]; then
> + echo "Skipping peer config $peer_config because public key is
> not defined."
> + return 0
> + fi
I guess there will be other error conditions that could cause the wg
setup to fail... is there any more robust way to check
Hi,
I think this behavior is not really acceptable. Programs, init scripts,
hotplug events etc. should not automatically modify (and commit) uci
configurations, especially not such vital ones like the network config.
The main problem I see is that you do not know what state the config is
in at an
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.
To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Hi Adrian,
thanks a lot for patch
Why are this patches not merged upstream?
You always have to rebase and solve merge conflicts if you work on 60
GHz. :/
I would really appreciate it if this is merged. And if there is a reason
why this stuff is not getting upstream, I volunteer to work on it.
Best,
Nick
On 08.11.19 19:14, Adrian
35 matches
Mail list logo
