Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi Mathias, Actually the current default for the ath79 architecture is to pad the partitions as seen on target/linux/ath79/image/Makefile: define Device/Default [...] IMAGE/sysupgrade.bin = append-kernel | pad-to (BLOCKSIZE) | \ append-rootfs | pad-rootfs |

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi Steve, Thank you for testing. You implemented my suggestion correctly but it seems that it didn't actually pad anything (the sizes of the partitions should be rounded to the next 0x1 block). Please allow me a few days (real-life constraints) to test some changes to the common-tp-link.mk

Re: [OpenWrt-Devel] hostapd and Linux bridges

2020-01-21 Thread Daniel Golle
On Tue, Jan 21, 2020 at 11:34:22PM +0100, Mathias Kresin wrote: > 21/01/2020 20:22, Daniel Golle: > > On Tue, Jan 21, 2020 at 07:40:42PM +0100, Bjørn Mork wrote: > > > Daniel Golle writes: > > > > > > > On proprietary APs it looks like port isolation is enabled or disabled > > > > globally in

Re: [OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end of available RAM

2020-01-21 Thread mail
>> To me it seems the LZMA_TEXT_START argument is overwritten to the old >> value by explicit declaration in >> >> target/linux/ath79/image/lzma-loader/src/Makefile > We've tested it for the Mikrotik PR, and it works with my patch. > I can't tell you why overwrite works this direction without

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Steve Brown
Hi Bruno, That didn't seem to solve the problem. The padding didn't seem to take effect. I reverted 0f81a0979 and 0c707d37b. dev:size erasesize name mtd0: 0002 0001 "factory-uboot" mtd1: 0002 0001 "u-boot" mtd2: 00ec 0001 "firmware" mtd3: 001a3a07 0001

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Mathias Kresin
21/01/2020 22:10, Bruno Pena: Hi everyone, I was finally able to replicate the issue you are observing. The problem comes from the fact that the kernel partition on the TP-Link images is not padded to the write blocksize - which can be observed on the dmesg from Steve: [0.450987]

Re: [OpenWrt-Devel] hostapd and Linux bridges

2020-01-21 Thread Mathias Kresin
21/01/2020 20:22, Daniel Golle: On Tue, Jan 21, 2020 at 07:40:42PM +0100, Bjørn Mork wrote: Daniel Golle writes: On proprietary APs it looks like port isolation is enabled or disabled globally in Linux' bridge code using sysctl or other methods, an approach which is unlikely to get accepted

Re: [OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end of available RAM

2020-01-21 Thread Paul Fertser
Hi, On Tue, Jan 21, 2020 at 10:48:28PM +0100, m...@adrianschmutzler.de wrote: > I can't tell you why overwrite works this direction without further > research though. "If a variable has been set with a command argument (*note Overriding Variables: Overriding.), then ordinary assignments in the

Re: [OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end of available RAM

2020-01-21 Thread mail
Hi David, > -Original Message- > From: David Bauer [mailto:m...@david-bauer.net] > Sent: Dienstag, 21. Januar 2020 22:19 > To: Adrian Schmutzler > Cc: openwrt-devel > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end > of available RAM > > Hello Adrian, > > On

Re: [OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end of available RAM

2020-01-21 Thread David Bauer
Hello Adrian, On 1/21/20 9:57 PM, Adrian Schmutzler wrote: > @@ -10,7 +11,7 @@ define Build/loader-common > $(MAKE) -C lzma-loader \ > PKG_BUILD_DIR="$@.src" \ > TARGET_DIR="$(dir $@)" LOADER_NAME="$(notdir $@)" \ > - LZMA_TEXT_START=0x80a0

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi everyone, I was finally able to replicate the issue you are observing. The problem comes from the fact that the kernel partition on the TP-Link images is not padded to the write blocksize - which can be observed on the dmesg from Steve: [0.450987] 0x-0x001a39ea : "kernel"

Re: [OpenWrt-Devel] GSoC 2020 - reminder for ideas

2020-01-21 Thread Paul Spooren
Hi, I added a device pages project idea. That could come in handy with the page refresh and all. Also I'm trying to setup a devices.git repository storing all relevant metadata. That could be an additional project or I just do it on my own and leave the rendering to a student. Best, Paul

[OpenWrt-Devel] [PATCH] ath79: move lzma-loader to the end of available RAM

2020-01-21 Thread Adrian Schmutzler
In certain cases, the uncompressed initramfs image will overwrite the lzma-loader, which is currently only 10 MB away from kernel image start. To prevent this, change LZMA_TEXT_START to 24 MB, so loader and compressed image have 8 MB at the end of RAM and uncompressed image has 24 MB available.

[OpenWrt-Devel] [PATCH] ramips: define SOC only once for uniform targets

2020-01-21 Thread Adrian Schmutzler
In ramips, all devices in mt7621, mt76x8 and rt288x subtarget have the same value set to the SOC variable individually. This introduces a non-device-dependent variable COMMON_SOC, which is used if no specific SOC is set for a device, and thus reduces the number of redundant definitions

Re: [OpenWrt-Devel] [PATCH 2/2] generic at803x: remove unneeded patches

2020-01-21 Thread Christian Lamparter
Hello, On Tue, Jan 21, 2020 at 9:11 PM David Bauer wrote: > > - Remove the "RGMII TX delay fixup" hack and the associated >DT-property. It was never used in a DT-based platform and >solved a problem which can be mitigated by using correct >delays on the MAC side. > Can you tell us

[OpenWrt-Devel] [PATCH 2/2] generic at803x: remove unneeded patches

2020-01-21 Thread David Bauer
- Remove the "RGMII TX delay fixup" hack and the associated DT-property. It was never used in a DT-based platform and solved a problem which can be mitigated by using correct delays on the MAC side. - Remove the patch to enable platform-data support for the at803x driver. It was

[OpenWrt-Devel] [PATCH 1/2] ath79: use upstream properties to disable EEE

2020-01-21 Thread David Bauer
The hack-patch which introduced the "at803x-disable-smarteee" for disabling SmartEEE did in fact not disable SmartEEE but rather disabled 802.3az "standard" EEE. This can be done by using the upstream properties "eee-broken-100tx" and "eee-broken-1000t". EEE is then disabled by the PHY subsystem.

Re: [OpenWrt-Devel] hostapd and Linux bridges

2020-01-21 Thread Daniel Golle
On Tue, Jan 21, 2020 at 07:40:42PM +0100, Bjørn Mork wrote: > Daniel Golle writes: > > > On proprietary APs it looks like port isolation is enabled or disabled > > globally in Linux' bridge code using sysctl or other methods, an > > approach which is unlikely to get accepted into the Kernel,

Re: [OpenWrt-Devel] [PATCH 19.07] ramips: mt7621: ubnt-erx: allow sysupgrade from master

2020-01-21 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Piotr Dymacz > Sent: Dienstag, 21. Januar 2020 20:13 > To: Petr Štetiar ; openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH 19.07] ramips: mt7621: ubnt-erx:

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi Petr, Thank you for reverting the patches. I'm trying to replicate the issue but so far I haven't had any luck, and just by looking at the code I'm not seeing where/what is could be breaking. Regarding the upstream patch, that one is just an enabler (read: it only extends the

Re: [OpenWrt-Devel] [PATCH 19.07] ramips: mt7621: ubnt-erx: allow sysupgrade from master

2020-01-21 Thread Piotr Dymacz
Hi Petr, On 20.01.2020 20:40, Petr Štetiar wrote: Currently it's not possible to downgrade from master: Device ubiquiti,edgerouterx not supported by this image Supported devices: ubnt-erx So fix it by adding a DTS based device name from master into SUPPORTED_DEVICES list. Signed-off-by:

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Petr Štetiar
Bruno Pena [2020-01-21 14:53:54]: Hi, > Based on the last comment from Steve (fstools patch was not reverted), I'm > not sure if that's the root cause. you need to find out, but that Daniel's remark seems legit to me, your patch likely changed the mtd device open order/flags. > The kernel

Re: [OpenWrt-Devel] hostapd and Linux bridges

2020-01-21 Thread Bjørn Mork
Daniel Golle writes: > On proprietary APs it looks like port isolation is enabled or disabled > globally in Linux' bridge code using sysctl or other methods, an > approach which is unlikely to get accepted into the Kernel, also given > that the netlink interface already exists and allows doing

[OpenWrt-Devel] hostapd and Linux bridges

2020-01-21 Thread Daniel Golle
Hi! I was trying to use client isolation on a dual-band router running OpenWrt and run into a rather trivial problem: Despite hostapd supporting client isolation (ap_isolate=1), on devices with multiple radios (dual-band or tri-band) this alone won't have the desired effect as AP interfaces

Re: [OpenWrt-Devel] [PATCH] urngd: Fix entropy provider daemon

2020-01-21 Thread Petr Štetiar
Cristian Ciocaltea [2020-01-21 16:43:24]: Hi, > This patch brings the following fixes: > - poll /dev/random for unblocking write operations, instead of read > - register the low entropy callback after uloop initialization, not > before nice find, thanks! I'm going to push urngd 1.0.2 with

[OpenWrt-Devel] Review Semtech SX150x I2C GPIO expander for support of Netgear R6800

2020-01-21 Thread Adrian Schmutzler
Hi, is there someone who can/wants to review the Semtech SX150x I2C GPIO expander implemented for Netgear R6800 in https://github.com/openwrt/openwrt/pull/2614 ? Best Adrian openpgp-digital-signature.asc Description: PGP signature ___

[OpenWrt-Devel] [PATCH 1/2] wireguard: bump to 0.0.20200121

2020-01-21 Thread Jason A. Donenfeld
* Makefile: strip prefixed v from version.h This fixes a mistake in dmesg output and when parsing the sysfs entry in the filesystem. * device: skb_list_walk_safe moved upstream This is a 5.6 change, which we won't support here, but it does make the code cleaner, so we make this change to keep

[OpenWrt-Devel] [PATCH 2/2] wireguard-tools: bump to 1.0.20200121

2020-01-21 Thread Jason A. Donenfeld
* Makefile: remove pwd from compile output * Makefile: add standard 'all' target * Makefile: evaluate git version lazily Quality of life improvements for packagers. * ipc: simplify inflatable buffer and add fuzzer * fuzz: add generic command argument fuzzer * fuzz: add set and setconf fuzzers

[OpenWrt-Devel] [PATCH] urngd: Fix entropy provider daemon

2020-01-21 Thread Cristian Ciocaltea
From: Cristian Ciocaltea The OpenWrt Jitter RNG daemon is currently unable to continuously provide entropy, except once on process startup. This patch brings the following fixes: - poll /dev/random for unblocking write operations, instead of read - register the low entropy callback after uloop

Re: [OpenWrt-Devel] Migration in ath79 for swapped ethernet

2020-01-21 Thread Ansuel Smith
Why not add an additional step in the sysupgrade function. Something to alert people that switch configuration needs to be migrated and give the option to do the change itself, use a migration script or use the default option? I think something like that should be implemented anyway since it's

Re: [OpenWrt-Devel] Migration in ath79 for swapped ethernet

2020-01-21 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Piotr Dymacz > Sent: Dienstag, 21. Januar 2020 00:34 > To: m...@adrianschmutzler.de; 'David Bauer' ; > gch981...@gmail.com > Cc: openwrt-devel@lists.openwrt.org > Subject: Re:

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi Daniel, Based on the last comment from Steve (fstools patch was not reverted), I'm not sure if that's the root cause. The kernel patch (which when reverted makes rootfs_data writable again) only enforces the parent mtd access mode on the sub-partitions. When I look at the DTS file for this

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Steve Brown
I only had to revert the de80424f7 patch. Steve On Tue, 2020-01-21 at 13:06 +0100, Bruno Pena wrote: > Thank you for the details. > Did you had only to revert de80424f7 (kernel patch) or did you also > had to revert the fstools patch? > > Best regards, > Bruno Pena > > On Tue, Jan 21, 2020,

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Thank you for the details. Did you had only to revert de80424f7 (kernel patch) or did you also had to revert the fstools patch? Best regards, Bruno Pena On Tue, Jan 21, 2020, 12:09 Steve Brown wrote: > Below: > > Steve > > > > /proc/cmdline: >

Re: [OpenWrt-Devel] [PATCH] [19.07] ramips: add factory image for Netgear R6350

2020-01-21 Thread Adrian Schmutzler
Hi, I will leave that decision to David, who merged it in the first place. Best Adrian > -Original Message- > From: Christoph Krapp [mailto:achte...@googlemail.com] > Sent: Dienstag, 21. Januar 2020 12:01 > To: openwrt-devel@lists.openwrt.org > Subject: [OpenWrt-Devel] [PATCH] [19.07]

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Steve Brown
Below: Steve /proc/cmdline: console=ttyS0,115200n8 rootfstype=squashfs,jffs2 /proc/mtd: mtd0: 0002 0001 "factory-uboot" mtd1: 0002 0001 "u-boot" mtd2: 00ec 0001 "firmware" mtd3: 001a38de 0001 "kernel" mtd4: 00d1c722 0001 "rootfs"

[OpenWrt-Devel] [PATCH] [19.07] ramips: add factory image for Netgear R6350

2020-01-21 Thread Christoph Krapp via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- As support for the mt7615e wifi

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Daniel Golle
Hi Bruno, Hi Steve, On Tue, Jan 21, 2020 at 11:24:28AM +0100, Bruno Pena wrote: > Please also include the contents of "dmesg" and of the files > "/proc/cmdline" and "/proc/mtd". > > Best regards, > Bruno Pena > > On Tue, Jan 21, 2020, 11:01 Bruno Pena wrote: > > > Hi Steve, > > > > These

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Steve Brown
Hi Bruno, The device is a TPLink Archer A7V5 (MIPS Qualcomm Atheros QCA956X ver 1 rev 0) The flash layout is: [0.403133] m25p80 spi0.0: w25q128 (16384 Kbytes) [0.408045] 7 fixed-partitions partitions found on MTD device spi0.0 [0.414637] Creating 7 MTD partitions on "spi0.0": [

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Please also include the contents of "dmesg" and of the files "/proc/cmdline" and "/proc/mtd". Best regards, Bruno Pena On Tue, Jan 21, 2020, 11:01 Bruno Pena wrote: > Hi Steve, > > These patches should only impact partitions that are marked as read only. > Can you please provide more details

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Bruno Pena
Hi Steve, These patches should only impact partitions that are marked as read only. Can you please provide more details about your configuration? (architecture, device profile, mtd layout, the mtd partition generating the error) Best regards, Bruno Pena On Tue, Jan 21, 2020, 10:51 Steve Brown

Re: [OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

2020-01-21 Thread Steve Brown
Hi Bruno, On Sat, 2020-01-04 at 12:52 +0100, Bruno Pena wrote: > This patch enables fstools to open read-only MTD partitions, which in > turn also enables OpenWrt to boot from read-only partitions. > > The use of read-only partitions is of special importance for WiFi- > only > devices, where a

[OpenWrt-Devel] [PATCH procd 2/2] state: fix reboot causing shutdown inside LXC container

2020-01-21 Thread Petr Štetiar
Executing `reboot` command in OpenWrt system runing inside LXC container results in a shutdown of the container instead of rebooting the container. This appears to have been caused by commit 832369078d81 ("state: fix shutdown when running in a container (FS#2425)"), which exits the pid einz

[OpenWrt-Devel] [PATCH procd 1/2] instance: provide error feedback if ujail binary is missing

2020-01-21 Thread Petr Štetiar
Otherwise it's quite hard to track such issues. While at it, be DRY and use UJAIL_BIN_PATH constant for ujail binary. Signed-off-by: Petr Štetiar --- service/instance.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/service/instance.c b/service/instance.c index