[OpenWrt-Devel] ag71xx: fix return value check in ag71xx_probe()

2020-02-06 Thread Rosen Penev
From: Wei Yongjun In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun Reviewed-by: Oleksij

Re: [OpenWrt-Devel] [PATCH] ath79: ag71xx: use netif_receive_skb_list on 4.19

2020-02-06 Thread Chuanhong Guo
On Tue, Jan 7, 2020 at 8:12 AM Rosen Penev wrote: > > From: Chuanhong Guo > > This new function make batch processing of network packets possible, > which slightly improves performance. > > Signed-off-by: Chuanhong Guo > Tested-by: Rosen Penev > --- > around a 20mbps improvement is measured

Re: [OpenWrt-Devel] Random data on rootfs_data for tp-wr2543nd-v1 only with ath79

2020-02-06 Thread Chuanhong Guo
Hi! On Fri, Feb 7, 2020 at 6:44 AM Luiz Angelo Daros de Luca wrote: > > Hello, > > I isolated the problem to be kernel upgrade from 4.14 to 4.19. If I build > ath79 with 4.14, it simply works. > The mtd problem also happens while booting 4.19 without touching the flash > 4.19 (using initram

Re: [OpenWrt-Devel] [PATCH/RFC] ath79: ar933x_uart: set UART_CS_{RX, TX}_READY_ORIDE

2020-02-06 Thread Chuanhong Guo
Hi! On Fri, Feb 7, 2020 at 2:11 AM Daniel Golle wrote: > > On AR934x this UART is usually not initialized by the bootloader > as it is only used as a secondary serial port while the primary > UART is a newly introduced NS16550-compatible. > In order to make use of the ar933x-uart on AR934x

Re: [OpenWrt-Devel] [PATCH 3/3] ath79: add support for Teltonika RUT955

2020-02-06 Thread Chuanhong Guo
Hi! some minor comments below: On Thu, Feb 6, 2020 at 1:07 AM Daniel Golle wrote: ... > + > + gpio_ext_spi { > + compatible = "spi-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <_led_spi_gpio>; > + #address-cells = <1>; > +

Re: [OpenWrt-Devel] Random data on rootfs_data for tp-wr2543nd-v1 only with ath79

2020-02-06 Thread Luiz Angelo Daros de Luca
Hello, I isolated the problem to be kernel upgrade from 4.14 to 4.19. If I build ath79 with 4.14, it simply works. The mtd problem also happens while booting 4.19 without touching the flash 4.19 (using initram image). Is there a mechanism to do a kernel bisect in OpenWrt? Or does anybody have

[OpenWrt-Devel] [PATCH] include/cmake: fix compilation with a host subdir

2020-02-06 Thread Rosen Penev
Some packages such as libcxx do not accept being build in the same directory, which breaks host compilation. This commit adds the same behavior present for target builds. Signed-off-by: Rosen Penev --- include/cmake.mk | 4 +++- include/host-build.mk | 2 +- 2 files changed, 4

[OpenWrt-Devel] [PATCH/RFC] ath79: ar933x_uart: set UART_CS_{RX, TX}_READY_ORIDE

2020-02-06 Thread Daniel Golle
On AR934x this UART is usually not initialized by the bootloader as it is only used as a secondary serial port while the primary UART is a newly introduced NS16550-compatible. In order to make use of the ar933x-uart on AR934x without RTS/CTS hardware flow control, one needs to set the

Re: [OpenWrt-Devel] [PATCH] ath79: add new ar934x spi driver

2020-02-06 Thread Piotr Dymacz
Hi Chuanhong, On 06.02.2020 17:01, Chuanhong Guo wrote: Hi! On Thu, Feb 6, 2020 at 11:29 PM Piotr Dymacz wrote: Don't you think that ~24h for review this kind of patch wasn't enough? I've sent the patch upstream and got positive review there.[0] two minor comments there are already

Re: [OpenWrt-Devel] [PATCH] ath79: add new ar934x spi driver

2020-02-06 Thread Chuanhong Guo
Hi! On Thu, Feb 6, 2020 at 11:29 PM Piotr Dymacz wrote: > Don't you think that ~24h for review this kind of patch wasn't enough? I've sent the patch upstream and got positive review there.[0] two minor comments there are already addressed in my final commit. And I've done flash reading and

Re: [OpenWrt-Devel] [PATCH] ath79: add new ar934x spi driver

2020-02-06 Thread Piotr Dymacz
Hi Chuanhong, On 05.02.2020 15:44, Chuanhong Guo wrote: A new shift mode was introduced since ar934x which has a way better performance than current bitbang driver and can handle higher spi clock properly. This commit adds a new driver to make use of this new feature. This new driver has

[OpenWrt-Devel] [PATCH] kernel: rewrite run_parsers_by_type() to use add_mtd_partitions()

2020-02-06 Thread Rafał Miłecki
From: Rafał Miłecki Make run_parsers_by_type() more similar to the parse_mtd_partitions(): 1. Use struct mtd_partitions 2. Use add_mtd_partitions() This change simplifies run_parsers_by_type() by: 1. Dropping loop 2. Dropping code getting partition properties (name, offset, size) Moreover this

Re: [OpenWrt-Devel] [PATCH 3/3] ath79: add support for Teltonika RUT955

2020-02-06 Thread Simonas Tamošaitis
Hello, On 2/6/20 12:24 PM, Adrian Schmutzler wrote: Hi, + + led_system_green: system_green { + label = "rut955:green:system"; + gpios = <_ext 6 GPIO_ACTIVE_HIGH>; + default-state = "on"; +

[OpenWrt-Devel] tiny subtarget on ramips

2020-02-06 Thread Adrian Schmutzler
Hi, we currently have a PR [1] where somebody wants to set SMALL_FLASH for mt7620 in ramips target due to kernel size restriction for that particular device. I'm actually not too fond of doing that to all the other devices because of one single device needing it. However, I wonder whether we

Re: [OpenWrt-Devel] [PATCH 3/3] ath79: add support for Teltonika RUT955

2020-02-06 Thread Adrian Schmutzler
Hi, > > > + > > > + led_system_green: system_green { > > > + label = "rut955:green:system"; > > > + gpios = <_ext 6 GPIO_ACTIVE_HIGH>; > > > + default-state = "on"; > > > + linux,default-trigger = "phy0tpt"; > > > > tpt